>From WiXUI_Mondo.wxs

            <Publish Dialog="SetupTypeDlg" Control="Back"
Event="NewDialog" Value="LicenseAgreementDlg">1</Publish>
            <Publish Dialog="SetupTypeDlg" Control="TypicalButton"
Event="NewDialog" Value="VerifyReadyDlg">1</Publish>
            <Publish Dialog="SetupTypeDlg" Control="CustomButton"
Event="NewDialog" Value="CustomizeDlg">1</Publish>
            <Publish Dialog="SetupTypeDlg" Control="CompleteButton"
Event="NewDialog" Value="VerifyReadyDlg">1</Publish>

            <Publish Dialog="CustomizeDlg" Control="Back"
Event="NewDialog" Value="MaintenanceTypeDlg" Order="1">WixUI_InstallMode
= "Change"</Publish>
            <Publish Dialog="CustomizeDlg" Control="Back"
Event="NewDialog" Value="SetupTypeDlg" Order="2">WixUI_InstallMode =
"InstallCustom"</Publish>
            <Publish Dialog="CustomizeDlg" Control="Next"
Event="NewDialog" Value="VerifyReadyDlg">1</Publish>

>From SetupTypeDlg.wxs

                <Control Id="TypicalButton" Type="PushButton" X="40"
Y="65" Width="80" Height="17"
ToolTip="!(loc.SetupTypeDlgTypicalButtonTooltip)" Default="yes"
Text="!(loc.SetupTypeDlgTypicalButton)">
                    <Publish Property="WixUI_InstallMode"
Value="InstallTypical">1</Publish>
                    <Publish Event="SetInstallLevel"
Value="3">1</Publish>
                </Control>
                <Control Id="CustomButton" Type="PushButton" X="40"
Y="118" Width="80" Height="17"
ToolTip="!(loc.SetupTypeDlgCustomButtonTooltip)"
Text="!(loc.SetupTypeDlgCustomButton)">
                    <Publish Property="WixUI_InstallMode"
Value="InstallCustom">1</Publish>
                </Control>
                <Control Id="CompleteButton" Type="PushButton" X="40"
Y="171" Width="80" Height="17"
ToolTip="!(loc.SetupTypeDlgCompleteButtonTooltip)"
Text="!(loc.SetupTypeDlgCompleteButton)">
                    <Publish Property="WixUI_InstallMode"
Value="InstallComplete">1</Publish>
                    <Publish Event="SetInstallLevel"
Value="1000">1</Publish>
                </Control>


That code is the same in both WiX 3.0 & 3.5 sources. Do you see the
'Publish Property="WixUI_InstallMode"' sections? Those are what's
causing you your issue, WiXUI_InstallMode isn't being set until you
click on the Typical, Custom or Complete buttons. You're using a
variable in a condition which isn't set until the condition is checked
at least once. Chicken & egg, Catch 22, call it what you like, you can't
get a meaningful result from a logical operation variable that is null
unless you're checking if it is or isn't null (which you're clearly
not). CustomizeDlg has nothing to do with the problem, your Customise
button spawns the CustomizeDlg so the variable would obviously be set
once it's shown otherwise how would it ever be shown? There aren't any
other ways I can say this, either remove the checks or live with the
behaviour. Have you even tried removing them to see if I'm actually
correct or not or are you just dismissing my advice out of hand?

Palbinder Sandher 
Software Deployment & IT Administrator
T: +44 (0) 141 945 8500 
F: +44 (0) 141 945 8501 

http://www.iesve.com 
**Design, Simulate + Innovate with the <Virtual Environment>**
Integrated Environmental Solutions Limited. Registered in Scotland No.
SC151456 
Registered Office - Helix Building, West Of Scotland Science Park,
Glasgow G20 0SP
Email Disclaimer

-----Original Message-----
From: Mark Simonetti [mailto:ma...@opalsoftware.co.uk] 
Sent: 20 September 2010 09:35
To: General discussion for Windows Installer XML toolset.
Subject: Re: [WiX-users] Having to click twice to proceed.

  The WixUI_InstallMode checks are there in the default wixui_mondo.wxs
file - all I've done is added the LEGACY_APPDATA check.  Absolutely
nothing changes in the log between the first click and the second click,
it's all very strange!  It only does it when the LEGACY_APPDATA check
fails (i.e. the registy value is not set), and it only does it on the
SetupTypeDlg - I have the same check in CusomizeDlg.

Mark.


On 17/09/2010 16:29, Pally Sandher wrote:
> I didn't expect that to help much to be honest. WiXUI_InstallMode 
> isn't being set until you click the button the first time on the 
> SetupTypeDlg as your logs&  the SetupTypeDlg.wxs in the WiX sources
will show.
>
> You need to remove the checking of the WiXUI_InstallMode property from

> the SetupTypeDlg buttons. If you only want to show the MigrateDlg on 
> first install, not repair, modify etc condition it with something more

> appropriate like NOT Installed.
>
> Palbinder Sandher
> Software Deployment&  IT Administrator
> T: +44 (0) 141 945 8500
> F: +44 (0) 141 945 8501
>
> http://www.iesve.com
> **Design, Simulate + Innovate with the<Virtual Environment>** 
> Integrated Environmental Solutions Limited. Registered in Scotland No.
> SC151456
> Registered Office - Helix Building, West Of Scotland Science Park, 
> Glasgow G20 0SP Email Disclaimer
>
> -----Original Message-----
> From: Mark Simonetti [mailto:ma...@opalsoftware.co.uk]
> Sent: 17 September 2010 14:28
> To: General discussion for Windows Installer XML toolset.
> Subject: Re: [WiX-users] Having to click twice to proceed.
>
>    Hi Pally,
> Thanks for your response.
> It hasn't made any difference though :-( Nothing extra appears in the 
> log between the first click and the second click..
>
> Mark.
>
>
> On 17/09/2010 12:53, Pally Sandher wrote:
>> Try changing your conditions to
>> (LEGACY_APPDATA) AND (WixUI_InstallMode = "InstallCustom" OR 
>> WixUI_InstallMode = "InstallTypical" OR WixUI_InstallMode =
>> "InstallComplete")
>> and
>> (NOT LEGACY_APPDATA) AND (WixUI_InstallMode = "InstallCustom" OR 
>> WixUI_InstallMode = "InstallTypical" OR WixUI_InstallMode =
>> "InstallComplete")
>>
>> instead as that's more semantically correct in Windows Installer.
>>
>> Have you checked a verbose log to see when WiXUI_InstallMode is being

>> set?
>>
>> Palbinder Sandher
>> Software Deployment&   IT Administrator
>> T: +44 (0) 141 945 8500
>> F: +44 (0) 141 945 8501
>>
>> http://www.iesve.com
>> **Design, Simulate + Innovate with the<Virtual Environment>** 
>> Integrated Environmental Solutions Limited. Registered in Scotland
No.
>> SC151456
>> Registered Office - Helix Building, West Of Scotland Science Park, 
>> Glasgow G20 0SP Email Disclaimer
>>
>> -----Original Message-----
>> From: Mark Simonetti [mailto:ma...@opalsoftware.co.uk]
>> Sent: 17 September 2010 11:49
>> To: General discussion for Windows Installer XML toolset.
>> Subject: Re: [WiX-users] Having to click twice to proceed.
>>
>>     PS - it only seems to do it when the LEGACY_APPDATA is not set
> (i.e.
>> the registry search fails).
>>
>> Thanks,
>> Mark.
>> --
>>
>> On 17/09/2010 10:36, Mark wrote:
>>>      Hi all,
>>> I've made a copy of the wixui_mondo.wxs file to customize.  I've 
>>> changed the SetupType dialog to goto one dialog or another depending

>>> on a condition determined by a registry entry:
>>>
>>> <!-- Setup dialog -->
>>>
>>> <Publish Dialog="SetupTypeDlg" Control="Back" Event="NewDialog"
>>> Value="LicenseAgreementDlg">1</Publish>
>>> <Publish Dialog="SetupTypeDlg" Control="CustomButton"
>> Event="NewDialog"
>>> Value="CustomizeDlg">1</Publish>
>>>
>>> <Publish Dialog="SetupTypeDlg" Control="TypicalButton"
>> Event="NewDialog"
>>> Value="VerifyReadyDlg" Order="1">
>>>             (LEGACY_APPDATA = "") AND (WixUI_InstallMode =
>> "InstallCustom"
>>> OR WixUI_InstallMode = "InstallTypical" OR WixUI_InstallMode =
>>> "InstallComplete")
>>> </Publish>
>>>
>>> <Publish Dialog="SetupTypeDlg" Control="TypicalButton"
>> Event="NewDialog"
>>> Value="MigrateDlg" Order="2">
>>>             (NOT LEGACY_APPDATA = "") AND (WixUI_InstallMode = 
>>> "InstallCustom" OR WixUI_InstallMode = "InstallTypical" OR 
>>> WixUI_InstallMode = "InstallComplete")</Publish>
>>>
>>> <Publish Dialog="SetupTypeDlg" Control="CompleteButton"
>>> Event="NewDialog" Value="VerifyReadyDlg" Order="1">
>>>             (LEGACY_APPDATA = "") AND (WixUI_InstallMode =
>> "InstallCustom"
>>> OR WixUI_InstallMode = "InstallTypical" OR WixUI_InstallMode =
>>> "InstallComplete")
>>> </Publish>
>>>
>>> <Publish Dialog="SetupTypeDlg" Control="CompleteButton"
>>> Event="NewDialog" Value="MigrateDlg" Order="2">
>>>             (NOT LEGACY_APPDATA = "") AND (WixUI_InstallMode = 
>>> "InstallCustom" OR WixUI_InstallMode = "InstallTypical" OR 
>>> WixUI_InstallMode = "InstallComplete")</Publish>
>>>
>>> The reg search looks like this, and seems to work fine:
>>>
>>> <Property Id="LEGACY_APPDATA">
>>> <RegistrySearch Id="LEGACY_APPDATA_REGISTRY_SEARCH" Root="HKLM"
>>> Key="SOFTWARE\MyApp\Settings" Name="Data" Type="raw" />
</Property>
>>>
>>> The problem is when the SetupType dialog gets displayed, I have to 
>>> click twice on the Typical or Complete buttons to proceed.  If I go 
>>> back to the SetupType dialog, it's fine, it's always just the first 
>>> time in a particular installation session, almost like it's having 
>>> to go away and determine something.
>>>
>>> Any ideas anyone?
>>>
>>> Thanks,
>>> Mark.
>>>
>>>
>>> --------------------------------------------------------------------
>>> -
>>> -
>>> -------- Start uncovering the many advantages of virtual appliances 
>>> and start using them to simplify application deployment and 
>>> accelerate your shift to cloud computing.
>>> http://p.sf.net/sfu/novell-sfdev2dev
>>> _______________________________________________
>>> WiX-users mailing list
>>> WiX-users@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/wix-users
>>>
>>>
>> ---------------------------------------------------------------------
>> -
>> --
>> ------
>> Start uncovering the many advantages of virtual appliances and start 
>> using them to simplify application deployment and accelerate your 
>> shift to cloud computing.
>> http://p.sf.net/sfu/novell-sfdev2dev
>> _______________________________________________
>> WiX-users mailing list
>> WiX-users@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/wix-users
>>
>>
>>
>> ---------------------------------------------------------------------
>> -
>> -------- Start uncovering the many advantages of virtual appliances 
>> and start using them to simplify application deployment and 
>> accelerate your shift to cloud computing.
>> http://p.sf.net/sfu/novell-sfdev2dev
>> _______________________________________________
>> WiX-users mailing list
>> WiX-users@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/wix-users
>>
>>
>
> ----------------------------------------------------------------------
> --
> ------
> Start uncovering the many advantages of virtual appliances and start 
> using them to simplify application deployment and accelerate your 
> shift to cloud computing.
> http://p.sf.net/sfu/novell-sfdev2dev
> _______________________________________________
> WiX-users mailing list
> WiX-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/wix-users
>
>
>
> ----------------------------------------------------------------------
> -------- Start uncovering the many advantages of virtual appliances 
> and start using them to simplify application deployment and accelerate

> your shift to cloud computing.
> http://p.sf.net/sfu/novell-sfdev2dev
> _______________________________________________
> WiX-users mailing list
> WiX-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/wix-users
>
>


------------------------------------------------------------------------
------
Start uncovering the many advantages of virtual appliances and start
using them to simplify application deployment and accelerate your shift
to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
WiX-users mailing list
WiX-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-users



------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
WiX-users mailing list
WiX-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-users

Reply via email to