No sorry I am not using 3.8 I am using 3.7 with the Extended BA from Neil
-----Original Message----- From: Bruce Cran [mailto:br...@cran.org.uk] Sent: August-30-13 9:00 AM To: General discussion for Windows Installer XML toolset. Subject: Re: [WiX-users] Add text to final window in burn bootstrapper/installer Do you have a diff (e.g. using 'git diff') you can attach? -- Bruce Sent from my iPhone On 28 Aug 2013, at 18:29, Steven Ogilvie <steven.ogil...@titus.com> wrote: > Here is the code from BA > > Theme wxl file > <String Id="SuccessHeader">Setup Successful</String> <String > Id="SuccessSetupHeader">Setup Successful</String> <String > Id="SuccessUninstallHeader">Uninstall Successful</String> > > <String Id="FailureHeader">Setup Failed</String> <String > Id="FailureSetupHeader">Setup Failed</String> <String > Id="FailureUninstallHeader">Uninstall Failed</String> > > Theme xml file > <Page Name="Success"> > <Text Name="SuccessHeader" X="11" Y="80" Width="-11" Height="30" > FontId="2" HideWhenDisabled="yes" > DisablePrefix="yes">#(loc.SuccessHeader)</Text> > <Text Name="SuccessSetupHeader" X="11" Y="80" Width="-11" Height="30" > FontId="2" HideWhenDisabled="yes" > DisablePrefix="yes">#(loc.SuccessSetupHeader)</Text> > <Text Name="SuccessUninstallHeader" X="11" Y="80" Width="-11" > Height="30" FontId="2" HideWhenDisabled="yes" > DisablePrefix="yes">#(loc.SuccessUninstallHeader)</Text> > > <Page Name="Failure"> > <Text Name="FailureHeader" X="11" Y="80" Width="-11" Height="30" > FontId="2" HideWhenDisabled="yes" > DisablePrefix="yes">#(loc.FailureHeader)</Text> > <Text Name="FailureSetupHeader" X="11" Y="80" Width="-11" Height="30" > FontId="2" HideWhenDisabled="yes" > DisablePrefix="yes">#(loc.FailureSetupHeader)</Text> > <Text Name="FailureUninstallHeader" X="11" Y="80" Width="-11" > Height="30" FontId="2" HideWhenDisabled="yes" > DisablePrefix="yes">#(loc.FailureUninstallHeader)</Text> > > WixStandardBootstrapperApplication.cpp > > // Success page > WIXSTDBA_CONTROL_SUCCESS_HEADER, > WIXSTDBA_CONTROL_SUCCESS_SETUP_HEADER, > WIXSTDBA_CONTROL_SUCCESS_UNINSTALL_HEADER, > > // Failure page > WIXSTDBA_CONTROL_FAILURE_HEADER, > WIXSTDBA_CONTROL_FAILURE_SETUP_HEADER, > WIXSTDBA_CONTROL_FAILURE_UNINSTALL_HEADER, > > { WIXSTDBA_CONTROL_SUCCESS_HEADER, L"SuccessHeader" }, > { WIXSTDBA_CONTROL_SUCCESS_SETUP_HEADER, L"SuccessSetupHeader" }, > { WIXSTDBA_CONTROL_SUCCESS_UNINSTALL_HEADER, > L"SuccessUninstallHeader" }, > > { WIXSTDBA_CONTROL_FAILURE_HEADER, L"FailureHeader" }, > { WIXSTDBA_CONTROL_FAILURE_SETUP_HEADER, L"FailureSetupHeader" }, > { WIXSTDBA_CONTROL_FAILURE_UNINSTALL_HEADER, > L"FailureUninstallHeader" }, > > In method OnChangeState: > .. > else if (m_rgdwPageIds[WIXSTDBA_PAGE_SUCCESS] == dwNewPageId) // on the > "Success" page, check if the restart or launch button should be enabled. > ... > // Set the header of the failure page to either Setup or Uninstall > if (ThemeControlExists(m_pTheme, > WIXSTDBA_CONTROL_SUCCESS_SETUP_HEADER)) > { > ThemeControlEnable(m_pTheme, > WIXSTDBA_CONTROL_SUCCESS_SETUP_HEADER, BOOTSTRAPPER_ACTION_UNINSTALL < > m_plannedAction); > ThemeControlEnable(m_pTheme, > WIXSTDBA_CONTROL_SUCCESS_HEADER, FALSE); > } > else > { > ThemeControlEnable(m_pTheme, > WIXSTDBA_CONTROL_SUCCESS_HEADER, TRUE); > } > if (ThemeControlExists(m_pTheme, > WIXSTDBA_CONTROL_SUCCESS_UNINSTALL_HEADER)) > { > ThemeControlEnable(m_pTheme, > WIXSTDBA_CONTROL_SUCCESS_UNINSTALL_HEADER, BOOTSTRAPPER_ACTION_INSTALL > > m_plannedAction); > ThemeControlEnable(m_pTheme, > WIXSTDBA_CONTROL_SUCCESS_HEADER, FALSE); > } > else > { > ThemeControlEnable(m_pTheme, > WIXSTDBA_CONTROL_SUCCESS_HEADER, TRUE); > } > ... > else if (m_rgdwPageIds[WIXSTDBA_PAGE_FAILURE] == dwNewPageId) // on the > "Failure" page, show error message and check if the restart button should be > enabled. > ... > // Set the header of the failure page to either Setup or Uninstall > if (ThemeControlExists(m_pTheme, > WIXSTDBA_CONTROL_FAILURE_SETUP_HEADER)) > { > ThemeControlEnable(m_pTheme, > WIXSTDBA_CONTROL_FAILURE_SETUP_HEADER, BOOTSTRAPPER_ACTION_UNINSTALL < > m_plannedAction); > ThemeControlEnable(m_pTheme, > WIXSTDBA_CONTROL_FAILURE_HEADER, FALSE); > } > else > { > ThemeControlEnable(m_pTheme, > WIXSTDBA_CONTROL_FAILURE_HEADER, TRUE); > } > if (ThemeControlExists(m_pTheme, > WIXSTDBA_CONTROL_FAILURE_UNINSTALL_HEADER)) > { > ThemeControlEnable(m_pTheme, > WIXSTDBA_CONTROL_FAILURE_UNINSTALL_HEADER, BOOTSTRAPPER_ACTION_INSTALL > > m_plannedAction); > ThemeControlEnable(m_pTheme, > WIXSTDBA_CONTROL_FAILURE_HEADER, FALSE); > } > else > { > ThemeControlEnable(m_pTheme, > WIXSTDBA_CONTROL_FAILURE_HEADER, TRUE); > } > > That should be it :) > > Cheers, > > Steve > -----Original Message----- > From: Steven Ogilvie [mailto:steven.ogil...@titus.com] > Sent: August-28-13 1:14 PM > To: General discussion for Windows Installer XML toolset.; > afor...@cmu.edu > Subject: Re: [WiX-users] Add text to final window in burn > bootstrapper/installer > > You want me to make the change for 3.8 or your going to make the change? > > I can send you my code for the BA if you want :) > > -----Original Message----- > From: Bruce Cran [mailto:br...@cran.org.uk] > Sent: August-28-13 12:34 PM > To: afor...@cmu.edu; General discussion for Windows Installer XML toolset. > Subject: Re: [WiX-users] Add text to final window in burn > bootstrapper/installer > > Yes that was for Steven: he's made exactly the same changes I was hoping to > get around to making, and I'd like to see them get into WiX 3.8 if possible. > > -- > Bruce > > Sent from my iPhone > > On 28 Aug 2013, at 16:52, "Alain Forget" <afor...@cmu.edu> wrote: > >> I hope that's directed at Steven, because I don't know what that means (and >> I have yet to figure out where and how to modify .wxl files). >> >> Alain >> >> -----Original Message----- >> From: Bruce Cran [mailto:br...@cran.org.uk] >> Sent: Wednesday, August 28, 2013 11:39 AM >> To: General discussion for Windows Installer XML toolset. >> Subject: Re: [WiX-users] Add text to final window in burn >> bootstrapper/installer >> >> Could you sent a pull request to integrate this change upstream please? >> >> -- >> Bruce Cran >> >> Sent from my iPhone >> >> On 28 Aug 2013, at 14:28, Steven Ogilvie <steven.ogil...@titus.com> wrote: >> >>> Yes exactly >>> >>> BA is using the same property for Setup/Uninstall for the >>> success/failure string >>> >>> I fixed this by changing the code in BA and adding a few extra >>> string properties in the theme wxl file <String >>> Id="SuccessHeader">Setup Successful</String> <String >>> Id="SuccessSetupHeader">Setup Successful</String> <String >>> Id="SuccessUninstallHeader">Uninstall >>> Successful</String> <String Id="FailureHeader">Setup Failed</String> >>> <String Id="FailureSetupHeader">Setup Failed</String> <String >>> Id="FailureUninstallHeader">Uninstall Failed</String> >>> >>> BA: >>> >>> { WIXSTDBA_CONTROL_SUCCESS_HEADER, L"SuccessHeader" }, { >>> WIXSTDBA_CONTROL_SUCCESS_SETUP_HEADER, L"SuccessSetupHeader" }, { >>> WIXSTDBA_CONTROL_SUCCESS_UNINSTALL_HEADER, >>> L"SuccessUninstallHeader" }, >>> >>> { WIXSTDBA_CONTROL_FAILURE_HEADER, L"FailureHeader" }, { >>> WIXSTDBA_CONTROL_FAILURE_SETUP_HEADER, L"FailureSetupHeader" }, { >>> WIXSTDBA_CONTROL_FAILURE_UNINSTALL_HEADER, >>> L"FailureUninstallHeader" }, >>> >>> The in OnChangeState is where I set the correct string >>> >>> >>> -----Original Message----- >>> From: Bruce Cran [mailto:br...@cran.org.uk] >>> Sent: August-28-13 2:26 AM >>> To: General discussion for Windows Installer XML toolset. >>> Subject: Re: [WiX-users] Add text to final window in burn >>> bootstrapper/installer >>> >>> On 28/08/2013 06:07, Blair Murri wrote: >>>> As I understand it, page "Success" will be shown whenever the result of >>>> bundle application is successful but not when a failure occurs (when >>>> instead the "Failure" page will be shown). So, successful install, >>>> successful removal, successful modification, etc. >>>> If you can set bundle properties you can use that property's value as your >>>> text, maybe... >>> >>> There was a discussion on wix-devs about this a few months ago: the >>> WixStdBA bootstrapper needs changed to allow better text on the 'success' >>> pages. In particular, people have complained to me about the fact that >>> when uninstall completes it reports "Setup Success". >>> >>> -- >>> Bruce Cran >>> >>> -------------------------------------------------------------------- >>> - >>> --------- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL >>> 2012, more! >>> Discover the easy way to master current and previous Microsoft technologies >>> and advance your career. Get an incredible 1,500+ hours of step-by-step >>> tutorial videos with LearnDevNow. Subscribe today and save! >>> http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg. >>> clktrk _______________________________________________ >>> WiX-users mailing list >>> WiX-users@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/wix-users >>> >>> -------------------------------------------------------------------- >>> - >>> --------- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL >>> 2012, more! >>> Discover the easy way to master current and previous Microsoft >>> technologies and advance your career. Get an incredible 1,500+ hours >>> of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! >>> http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg. >>> clktrk _______________________________________________ >>> WiX-users mailing list >>> WiX-users@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/wix-users >> >> --------------------------------------------------------------------- >> - >> -------- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL >> 2012, more! >> Discover the easy way to master current and previous Microsoft >> technologies and advance your career. Get an incredible 1,500+ hours >> of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! >> http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg. >> c lktrk _______________________________________________ >> WiX-users mailing list >> WiX-users@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/wix-users >> >> >> --------------------------------------------------------------------- >> - >> -------- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL >> 2012, more! >> Discover the easy way to master current and previous Microsoft >> technologies and advance your career. Get an incredible 1,500+ hours >> of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! >> http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg. >> c lktrk _______________________________________________ >> WiX-users mailing list >> WiX-users@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/wix-users > > ---------------------------------------------------------------------- > -------- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL > 2012, more! > Discover the easy way to master current and previous Microsoft technologies > and advance your career. Get an incredible 1,500+ hours of step-by-step > tutorial videos with LearnDevNow. Subscribe today and save! > http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.c > lktrk _______________________________________________ > WiX-users mailing list > WiX-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wix-users > > ---------------------------------------------------------------------- > -------- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL > 2012, more! > Discover the easy way to master current and previous Microsoft technologies > and advance your career. Get an incredible 1,500+ hours of step-by-step > tutorial videos with LearnDevNow. Subscribe today and save! > http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.c > lktrk _______________________________________________ > WiX-users mailing list > WiX-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wix-users > > ---------------------------------------------------------------------- > -------- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL > 2012, more! > Discover the easy way to master current and previous Microsoft > technologies and advance your career. Get an incredible 1,500+ hours > of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! > http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.c > lktrk _______________________________________________ > WiX-users mailing list > WiX-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wix-users ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users
