Ahh, so you are doing your own downloading of the atom feed.  In 3.9, the 
engine will download the feed automatically if IDOK is returned from 
OnDetectUpdateBegin and there is an <Update /> element in the BA's manifest.  
It is possible that the changes I made to the engine are triggering an 
unintended side effect, but I can't see a clear path for how it could happen.

In DetectUpdateBegin, are you doing anything to the result?  IE, are you 
modifying e.Result?  It should default to IDNOACTION, but if you returned IDOK 
then the engine would attempt to download and parse your Atom feed for you, and 
notify your BA of what it finds for updates via a series of callbacks to 
OnDetectUpdate. If you aren't modifying e.Result, then the changes I 
implemented in the engine should not impact you.

A snip from the WixBA:

                   SyndicationFeed feed;
                    using (XmlReader reader = 
XmlReader.Create(response.GetResponseStream()))
                    {
                        feed = SyndicationFeed.Load(reader);
                    }

                    var updates = from entry in feed.Items
                                  from link in entry.Links
                                  from extension in entry.ElementExtensions
                                  where String.Equals(link.RelationshipType, 
"enclosure", StringComparison.Ordinal) &&
                                        String.Equals(extension.OuterNamespace, 
this.AppSyndicationNamespace, StringComparison.Ordinal) &&
                                        String.Equals(extension.OuterName, 
"version", StringComparison.Ordinal)
                                  select new Update()
                                  {
                                      Url = link.Uri.AbsoluteUri,
                                      Size = link.Length,
                                      Version = new 
Version(extension.GetObject<string>())
                                  };

                    Update update = updates.Where(u => u.Version > 
WixBA.Model.Version).OrderByDescending(u => u.Version).FirstOrDefault();
                    if (update == null)
                    {
                        WixBA.Model.Engine.SetUpdate(null, null, 0, 
UpdateHashType.None, null);
                        this.State = UpdateState.Current;
                    }
                    else
                    {
                        WixBA.Model.Engine.SetUpdate(null, update.Url, 
update.Size, UpdateHashType.None, null);
                        this.State = UpdateState.Available;
                    }


Is it getting the right update from " Update update = updates.Where(u => 
u.Version > WixBA.Model.Version).OrderByDescending(u => 
u.Version).FirstOrDefault(); " ?

What values are you passing to SetUpdate? IE, are you passing the incremental 
update, or the largest update?
-----Original Message-----
From: Phill Hogland [mailto:phogl...@rimage.com] 
Sent: Thursday, July 10, 2014 4:07 PM
To: wix-users@lists.sourceforge.net
Subject: Re: [WiX-users] 3.9.702 Bundle update behavior

My mba which has been working in this regard for about a year, is based on the 
Wix toolset Setup\WixBA\UpdateViewModel code which implements DetectUpdateBegin 
and DetectComplete.  Some time ago I added some customization to these handlers 
to allow our build process to place builds into a dev, test, and live area, and 
allow the mba to detect whether the setup is running on a marked dev or test 
system and get builds from those staging areas.  But those changes have also 
been working prior to seeing this new behavior.

DetectUpdateBegin spawns worker_DoWork which calls Engine.SetUpdate and return 
codes.  This code is the same as in the wix toolset source.

My atom feed document is generated at build time and I only include information 
for the one build that I intend to post to the web site, so it surprised me 
that the other intermediate bundles (other than the one the user launched) were 
still around on the local system to be reused.



--
View this message in context: 
http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/3-9-702-Bundle-update-behavior-tp7595761p7595765.html
Sent from the wix-users mailing list archive at Nabble.com.

------------------------------------------------------------------------------
Open source business process management suite built on Java and Eclipse Turn 
processes into business applications with Bonita BPM Community Edition Quickly 
connect people, data, and systems into organized workflows Winner of BOSSIE, 
CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft 
_______________________________________________
WiX-users mailing list
WiX-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-users

------------------------------------------------------------------------------
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
_______________________________________________
WiX-users mailing list
WiX-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-users

Reply via email to