> thank you Carlos for constructive notes on this patch. > I applied your suggestion on WApplication type.
Ok, thanks. I think your patch was well done and you did a nice work indeed. But I also wanted to train myself in reviewing other people's patches, and you were the first one to post patches (well, I also did write a few, but nobody cared/reviewed). I learned in the process, and at least some small points were polished in your patch. More people should review it though. > ps: git apply --whitespace=nowarn should've work too :) Yeah, I know. But I configure my xjed to highlight trailing whitespaces in blue against a black background, so it simply hurt my eyes to see a lot of those :-) -- To unsubscribe, send mail to [EMAIL PROTECTED]
