On Wed, 24 Dec 2008 14:10:33 +0100 (CET) Tamas TEVESZ <[email protected]> wrote:
> > hi, > > the following fixes a buffer overflow in SendHelperMessage() which i > started seeing recently on x64. > > > diff -r 5a2507602c48 src/misc.c > --- a/src/misc.c Sun Dec 14 19:59:05 2008 -0800 > +++ b/src/misc.c Wed Dec 24 13:26:51 2008 +0100 > @@ -1103,7 +1103,7 @@ > > len = (msg ? strlen(msg) : 0) + (workspace >=0 ? 4 : 0) + 1 ; > buffer = wmalloc(len+5); > - snprintf(buf, len, "%4i", len); > + snprintf(buf, sizeof(buf), "%4i", len); > memcpy(buffer, buf, 4); > buffer[4] = type; > i = 5; > > > -- > [-] > > mkdir /nonexistent > > > -- > To unsubscribe, send mail to [email protected]. This change is also already in current. Maybe you should download the latest snapshot so you can check if a change is already been incorporated: wget http://hg.windowmaker.info/wmaker/archive/default.tar.gz will get you the latest snapshot. Gilbert Ashley -- To unsubscribe, send mail to [email protected].
