On Fri, May 29, 2009 at 09:21:26PM +0200, Carlos R. Mafra wrote:
> On Sun 24.May'09 at  0:20:35 +0200, Samir SAADA wrote:
> > Here I tried to prevent the menu of windows to be displayed
> > in the other side of the screen if the window is half present
> > in the screen horizontally (ie x < 0)
> 
> Nice! I applied your patch here and it worked.
> 
> On rare occasions I was annoyed by this situation with the menu
> appearing in the other side, but now I won't be anymore.
> 
> > a worse problem with menu is that it disappears when
> > the window is half present in the window vertically
> > ie y < 0, that makes it not usable.
> 
> Did you consider the fix for the other case, where the
> window is at the botton of the screen, where y is bigger
> (or almost bigger) than the vertical resolution?
> 
no I didn't, the menu is "usable" in this case.
A down arrow is enough to make the menu appear by itself.
but I a gree it is anoying too.
I guess it is even more rare case :)


> 
> > Samir.
> 
> > diff -r 5a2507602c48 src/menu.c
> > --- a/src/menu.c    Sun Dec 14 19:59:05 2008 -0800
> > +++ b/src/menu.c    Sun May 24 00:07:51 2009 +0200
> > @@ -1165,8 +1165,8 @@
> >          }
> >  
> >          XMoveWindow(dpy, menu->frame->core->window, x, y);
> > -        menu->frame_x = x;
> > -        menu->frame_y = y;
> > +        menu->frame_x = (x<0) ? 0 : x;
> > +        menu->frame_y = (y<0) ? 0 : y;
> >          XMapWindow(dpy, menu->frame->core->window);
> >          wRaiseFrame(menu->frame->core);
> >          menu->flags.mapped = 1;
> 


-- 
To unsubscribe, send mail to [email protected].

Reply via email to