On Tue, Aug 25, 2009 at 1:40 PM, Martin Dietze<[email protected]> wrote:
> On Tue, August 25, 2009, gasol wrote:
>
>> Another problem is that wmaker dose not implement
>> _NET_WM_STATE_DEMANDS_ATTENTION.
>
> Yep, but that's beyond my personal scope for now as long as it
> does not fix any issue I am concerned with. There's probably
> still quite a list of issues like this which need to be
> addressed at some time.
>
>> What im saying is that the patch should be a little bit smarter in what it
>> do:
>>
>> _NET_ACTIVE_WINDOW
>> window = window to activate
>> message_type = _NET_ACTIVE_WINDOW
>> format = 32
>> data.l[0] = source indication
>> data.l[1] = timestamp
>> data.l[2] = requestor's currently active window, 0 if none
>> other data.l[] elements = 0
>>
>> Like for example take a peek at the source there, if its a 2 then the
>> message came from a pager, so it should not be ignored. If its a 1
>> then it came from an application, like firefox or pidigin, therefore
>> some users might wanna ignore it. If it is a 0 we dont know where it
>> came from, so we make up some rule about it...
>
> Hmm, not quite sure if I understand you completely, maybe you
> could provide a patch? Though I'd personally be happy to just
> ignore the event I think you have a good point.
>
Well based on the earlier patch, dont have time atm to write a "real" one
if (event->message_type == net_active_window) { // ACHTUNG! Lazy evaluation!
if(event->data.l[0] == 2 || ALLOW_ACTIVE_WINDOW_CHANGE(wwin) ||
wwin->frame->workspace == wwin->screen_ptr->current_workspace) {
wNETWMShowingDesktop(scr, False);
wMakeWindowVisible(wwin);
}
}
So we allow the change of the active window IF: its on the _same_
desktop OR if its explicitly sent from an pager OR we have made an
exception and lets a certain application change active window...
The third criteria would be added to our TODO list, if i get some time
over this weekend i could start snooping around how to do it...
Dont get me wrong i think its great that patches are coming in, but a
little discussion about the side effects are always a good thing! At
least before they are commited...
--
To unsubscribe, send mail to [email protected].
