Quoth Carlos R. Mafra,
I have just a small (and a bit irrelevant) comment about
cleanliness to make.
...
You added this with no spaces around the "+"
...
And then you "polluted" your next patch by adding the spaces where
they should have been in the first place.
I see what's happened. When I originally wrote the patch it had
the padding thing and the Xinerama fix together. I wanted to take
advantage of git and submit two patches. Looks like I didn't notice
until doing the second patch that the formatting of the existing code
has changed.
The original sources didn't have spaces around the operators, so
neither did my patch. The code in git does so I had to update things
to match it. So yes you are right I should have caught that fact when
doing patch 1.
--
To unsubscribe, send mail to [email protected].
