On Tue 15.Sep'09 at 3:47:52 +0400, Alexey I. Froloff wrote:
> On Mon, Sep 14, 2009 at 10:20:57PM +0200, Carlos R. Mafra wrote:
> > and I was wondering why it is necessary for 64-bits machines.
> This patch sucks.
Good, that is why I wanted to check.
> > But why do we want to change 'data' and 'pixel' for 64-bits machines?
> We don't. 'data' contains width, height and pixels. width and
> height defined in RImage as 'int'. Then 'data' is passed to
> XChangeProperty() as list of 32-bit quantities which is not true
> on 64-bit.
I don't understand the "is not true on 64-bit" part.
XChangeProperty(scr->display, win->view->window, scr->netwmIcon,
XA_CARDINAL, 32, PropModeReplace,
(unsigned char *)data, (image->width * image->height +
2));
'data' is being cast to the proper type as specified in the man page,
and as far as I understand there is no problem in doing that
cast in 32 or 64-bit mode. So what is not true?
> > data[o++] = image->width;
> Better make sure that image->width and image->height fits to
> CARD32 here and on next line.
I don't see why they wouldn't.
--
To unsubscribe, send mail to [email protected].
