On So 6.Dez'09 at 14:52:45 +0100, Nicolas Bonifas wrote: > >Ie, why not move the assignment of 'src' to after the test? > > I thought about this, but I checked the 3 different calls to > updateWorkspaceMenu (all in winmenu.c). They must all call > updateWorkspaceMenu with non-NULL pointers, so if we have a NULL > 'menu' pointer then we obviously have a major problem and it is > probably better to crash here than to silently return and fail a > little latter. > > This test is probably a remnant of earlier code.
It would have been better to include the above info in the original commit log, wouldn't it? Ok, so you thought more about this and checked things. I will apply it to 'next' now. As you already mentioned, if the check was ever used then wmaker would have crashed before. -- To unsubscribe, send mail to [email protected].
