On Sun, 29 Aug 2010 at 16:13:38 +0200, Andreas Metzler wrote:
>
> this is a first shot at improving wmaker's libraries, starting with
> libwraster. libwraster currently exports private symbols (e.g.
> RLoadGIF). It also does not yet use symbol versioning, which is not a big
> thing for a rarely used library but is nice to have anyway.
> 
> Comments welcome.

Caveat: I am not familiar with library management stuff.

> Andreas Metzler (3):
>   Set library version in configure.ac
>   Import ld-version-script.m4 from gnulib

[...]

>  configure.ac            |   44 ++++++++++++++++++++
>  m4/ld-version-script.m4 |   44 ++++++++++++++++++++

Why is it important to have this version control?

We already have an enough nightmare-inducing and bad-for-your-mental-health
configure.ac, and the first impression with reading the rules of
version control for those libraries in the comments added to configure.ac
is that nobody will probably ever care about changing those numbers.

What I am missing?

>   Add version script versioning for libwraster

>  wrlib/Makefile.am       |    6 ++-
>  wrlib/libwraster.map    |  102 
> +++++++++++++++++++++++++++++++++++++++++++++++

This one is OK, AFAICT. Exporting unneeded stuff is, well, unneeded.

>  5 files changed, 197 insertions(+), 3 deletions(-)
>  create mode 100644 m4/ld-version-script.m4
>  create mode 100644 wrlib/libwraster.map


-- 
To unsubscribe, send mail to [email protected].

Reply via email to