Tamas TEVESZ <[email protected]> wrote: [...] > --- > WINGs/WINGs/WUtil.h | 7 +++- > WINGs/string.c | 108 +++++++++++++++++++++++++++++++++++++++++++++++++++ > configure.ac | 8 ++++ > 3 files changed, 122 insertions(+), 1 deletions(-)
> diff --git a/WINGs/WINGs/WUtil.h b/WINGs/WINGs/WUtil.h > index de10a9d..61b19ad 100644 > --- a/WINGs/WINGs/WUtil.h > +++ b/WINGs/WINGs/WUtil.h > @@ -849,7 +849,12 @@ extern int WCErrorCode; > /*-------------------------------------------------------------------------*/ > - > +#ifndef HAVE_STRLCPY > +size_t strlcpy(char *, const char *, size_t); > +#endif > +#ifndef HAVE_STRLCAT > +size_t strlcat(char *, const char *, size_t); > +#endif Hello, I think having a general purpose string function like strlcpy in the pulic library libWutil is a bad idea. Just imagine a another project that also needs strlcpy an uses another #ifndef HAVE_STRLCPY pattern. If it also links against libWINGs it will end up with two conflicting implementations/prototypes. Stuff like this should not be exported by wmaker but only used internally. If libWUTIL is supposed to only be used internaly it should not be a dynamic library imho. cu andreas -- To unsubscribe, send mail to [email protected].
