On Sat, 9 Oct 2010 at 19:36:20 -0400, Brad Jorsch wrote: > On Fri, Oct 08, 2010 at 11:17:36PM +0200, Carlos R. Mafra wrote: > > > Perhaps I am missing something with this patch. But I think the diff > > below could be added on top of your series. I just tested it and > > I couldn't detect any bad effects (and no icon was saved in > > CachedPixmap even if there was an old "Icon=" line in > > WMWindowAttributes). What do you think? > > If a new version of the app supplies a cool new icon, wmaker won't > notice with your patch. And in fact, it will show the old icon until the > app is launched, change to the new icon while the app is running, and > then change back to the old when the app terminates.
Well, but in the (not common) situation that an app changes its icon, I think it makes sense to undock the "old" one and dock again using the cool new icon. The user would notice pretty quickly that the app is providing a new icon and do something about it (undock + dock again). What I don't like on general grounds is to do something useless most of the time to take care of situations which are easily worked around. > > Another thing. On wAppIconSave() you save the icon only if > > the app is docked. But what prevents wmaker from saving > > a new icon (rewriting the old) every time you open an > > already-docked application? > > Nothing does. If you can think of a good way to do "save it only if it > changed" without running into the problem above, go ahead. It feels better to have a light code path during app-openning time and do only the strictly necessary stuff. So I prefer to avoid having to rewrite the icon every single time. I think we can go one step further and my patch is one possible attempt at that. I'll probably commit it. -- To unsubscribe, send mail to [email protected].
