On Tue, Jul 3, 2012 at 11:12 AM, kix <[email protected]> wrote: > probably I am new reviewing patches, but... this patch is so big. I cannot > understand what you did. > You are changing the function names, moving functions with other names to > other files, adding arguments to functions, changing types,... all together > in the same patch. For me is too difficult. > > Please, wait the Carlos's or other developers reply before split this patch. > I don't want to make you work more.
I'm in the middle of a conference and will not have time to review this until the end of next week, but I also didn't like this aspect from the very brief look I gave at it. If you move functions you should do only that. I also didn't like changing the warning() to parser_warning() or something. I don't see the point in that and to make things worse it's done _silently_ in the middle of others things. Don't do that. -- To unsubscribe, send mail to [email protected].
