On 2012-11-12 23:00, BALATON Zoltan wrote:
On Mon, 12 Nov 2012, Carlos R. Mafra wrote:
Please do test the #next branch and report any problems (if any).
There has been a lot of code churn related to icons. Even though
they
look relative safe, regressions might be hiding somewhere.
I'm not sure if the "Ignore client supplied icon" option in the Icon
and Initial Workspace inspector is still working. At least Xfig now
has the icon I set in the app icon but displays its own icon in the
miniwindow (which is obscuring the tile completely).
Hi again,
there are two problems:
1. xfig don't have the WM_ICON_NAME set, therefore the function
wIconPaint() don't draw the title. You can try to set the value with
xprop, reload windowmaker and then the title will appear in xfig's icon.
The update pixmap function don't paint the background square because the
variable titled is created using the WM_ICON_NAME value too.
2. As I said in my final mail about icons (that was not my last mail
about icons :-) ), the icon image and the window image are different.
icon image is window->icon and window image is window->net_icon_image.
If the user sets the icon, then the selected icon is used in the window
(alt+tab) and in the icon, but if is not set, then the icons could be
different.
Comments about these problems are very welcome. Again, if WM_ICON_NAME
is not set, probably we could use something here.
Related to this, if the client supplied icon is too big (like for
gtk-demo for example) it is simply clipped and not resized. An
improvement though that it now seems to be centered at least. Could
the icon be resized (maybe before being cached) to improve this.
I sent a patch yesterday. The problem is that the wIconValidateIconSize
didn't check the width and the height size for the icon, only checked
one of them. The new patch check both values and holds the icon aspect
ratio.
Best regards,
kix
(snip)
Regards,
BALATON Zoltan
--
||// //\\// Rodolfo "kix" Garcia
||\\// //\\ http://www.kix.es/
--
To unsubscribe, send mail to [email protected].
