Hello,
This mail has been sent by the mailing list manager operating the
[email protected]
mailing list to the human moderators of the list.
Should the message at the bottom be allowed to be sent to the list?
If so, reply to this mail or send mail to
wmaker-dev-approve-bcecb7298c6c76e16b43e05b59b60ae6-3d9ca9fe9dd163ed5436460e17ed5...@lists.windowmaker.info
If not, send mail to
wmaker-dev-reject-bcecb7298c6c76e16b43e05b59b60ae6-8ac3d0581abcea2c6a2a1b5c90d7d...@lists.windowmaker.info
Thanks.
--- Begin Message ---
On Thu, Apr 08, 2010 at 11:14:14AM +0200, Carlos R. Mafra wrote:
>
> I would like to apply this, but the patch mixes the warning fixes
> with other things (like the piece in src/event.c which you had a
> second thought later in this thread).
They're all warning fixes, just for different warnings. For example, the
changes in src/event.c fix "warning: dereferencing pointer ‘sev’ does
break strict-aliasing rules".
The second thought was just because I found I had done it wrong.
> Can you separate the 100%-secure warning fixes from the less obvious
> stuff (e.g. the one which Tamas pointed out) and send them in different
> patches?
Ok.
> Furthermore, although it is not strongly required, it would be better if you
> could send the patches as described in The-perfect-Window-Maker-patch.txt.
Ok, patches to follow shortly. Note you may have some trouble with 0002,
"git am" seems to choke on patches against files with CRLF line endings.
It should apply cleanly with patch -p1.
--- End Message ---
