On Thu, 8 Apr 2010 at 14:43:48 -0400, Brad Jorsch wrote: > On Thu, Apr 08, 2010 at 11:14:14AM +0200, Carlos R. Mafra wrote: > > > > I would like to apply this, but the patch mixes the warning fixes > > with other things (like the piece in src/event.c which you had a > > second thought later in this thread). > > They're all warning fixes, just for different warnings. For example, the > changes in src/event.c fix "warning: dereferencing pointer ‘sev’ does > break strict-aliasing rules". > > The second thought was just because I found I had done it wrong. > > > Can you separate the 100%-secure warning fixes from the less obvious > > stuff (e.g. the one which Tamas pointed out) and send them in different > > patches? > > Ok. > > > Furthermore, although it is not strongly required, it would be better if > > you > > could send the patches as described in The-perfect-Window-Maker-patch.txt. > > Ok, patches to follow shortly. Note you may have some trouble with 0002, > "git am" seems to choke on patches against files with CRLF line endings. > It should apply cleanly with patch -p1.
Thanks Brad, I applied all the patches and I am much more confortable with their fine-grained nature now. -- To unsubscribe, send mail to [email protected].
