On Sun, 25 Jul 2010 at 18:05:30 +0200, Gilbert Netzer wrote: > > while trying out the Ubuntu wmaker package version 0.92.0-7ubuntu10 > (http://packages.ubuntu.com/lucid/wmaker) I found that WindowMaker > would crash with a buffer overflow in the SendHelperMessage function > during startup. > > There seems to be a bug in one of the snprintf calls where the len > parameter is passed also as the buffer length, leading to the > problem. > > The attached patch fixes the issue and allows WindowMaker to start.
Thanks for the letting us know about the patch! But I would say that Ubuntu's version of wmaker is a bit outdated. If you consider the version mantained at http://repo.or.cz/w/wmaker-crm.git this bug was fixed by Tamas TEVESZ in the following commit from 2008: commit e2b6a85e8042f21d3cca92c35ed315fc6ee3a6ce Author: Tamas TEVESZ <[email protected]> Date: Wed Dec 24 14:10:33 2008 +0100 Fix buffer overflow in SendHelperMessage() The following fixes a buffer overflow in SendHelperMessage() which i started seeing recently on x64. -- To unsubscribe, send mail to [email protected].
