On Fri, 17 Sep 2010 at 15:13:29 +0200, Tamas TEVESZ wrote: > the following is a touchup of bento's original work and that of i saw > later when trying to save. there is still one issue remaining, namely > that even after having claimed the bad item was cleared, it still > shows up on the editable menu popup, but it will not be present in the > saved menu or anywhere, as far as i can tell. > > i think this can sorta go in, credit is fully bento's.
Right, I dropped Bento's original patch and pushed yours (with your email as the commit log, lacking an alternative). [ I've noticed that Alexey put the "Signed-off-by:" line in his patches, and I think that it's a good idea to follow standard practices from other projects (linux-kernel in this case). Now that you credit Bento, I remember that in the linux-kernel mailing list people try to give credits by using a "Reported-by:" tag. So I've done this here, and added both your "Signed-off-by:" and a "Reported-by:" to Bento. And I think I will try to encourage this in wmaker-crm. So if you are doing patches with git, simply commit your changes with 'git commit -s' to add your signed-off-by. ] -- To unsubscribe, send mail to [email protected].
