how about this:

diff --git a/WINGs/memory.c b/WINGs/memory.c
index 9d770b0..bb6df5c 100644
--- a/WINGs/memory.c
+++ b/WINGs/memory.c
@@ -95,6 +95,7 @@ void *wmalloc(size_t size)
                        }
                }
        }
+       memset(tmp, 0, size);
        return tmp;
 }

cleaner drier healthier, and would help kill quite some individual 
memsets. maybe we should even consider calloc.

i'm thinking about making walloc (thus wutil) mandatory throughout all 
the tree (including utils and stuff). there are a small number (3-4 
that i remember) where malloc is used, and there's an actual sane 
error path should it fail, but i'm thinking, maybe these worth 
sacrificing for uniformity (walloc tries twice already, so in a sense 
it's even more forgiving...)


on a different note, i'm quite sure about this one:

diff --git a/src/application.c b/src/application.c
index 21155c7..ca1cf1a 100644
--- a/src/application.c
+++ b/src/application.c
@@ -192,7 +192,7 @@ void wApplicationExtractDirPackIcon(WScreen * scr, char 
*path, char *wm_instance
                        if (access(tmp, R_OK) == 0)
                                iconPath = tmp;
                }
-               if (!path) {
+               if (!iconPath) {
                        strcpy(tmp, path);
                        strcat(tmp, ".xpm");
                        if (access(tmp, R_OK) == 0)



-- 
[-]

mkdir /nonexistent


-- 
To unsubscribe, send mail to [email protected].

Reply via email to