On Mon, 21 Mar 2011 at 16:48:38 +0100, Szabó Ambrus wrote:
> From e9135c251452e16604f4efb8796246e1621239cf Mon Sep 17 00:00:00 2001
> From: Szabo Ambrus <[email protected]>
> Date: Mon, 21 Mar 2011 16:36:56 +0100
> Subject: [PATCH] Opaque Resize
You should write a bit more about the functionality you are adding in the
commit message. For example, that it's configurable through WPrefs in the
'Expert' panel, and more importantly what it is supposed to do and _how_ to
use it.
Why? Because I resize why windows with the keyboard as my windows don't even
have a 'resize bar' at all. With a "Opaque Resize" subject line I went straight
to testing with my usual keyboard resize and what? It didn't do the
"Opaque Resize" as promised.
Reading the source I noticed that it works only if you resize your windows
with the mouse on the resize bar. I realize that it can be a bit tricky to
think about that when writing the commit, but if you were more specific about
how to use the new functionality it would have saved me some minutes :-)
So I don't like this inconsistency with mouse x keyboard. Would it be possible
to make the keyboard resize be opaque too?
I realize now that wmaker is already inconsistent wrt to the "Opaque Move" too,
as there's no keyboard support too. Hopefully it can be fixed.
> --- a/WPrefs.app/Expert.c
> +++ b/WPrefs.app/Expert.c
> @@ -31,7 +31,7 @@ typedef struct _Panel {
>
> WMWidget *parent;
>
> - WMButton *swi[12];
> + WMButton *swi[13];
Right. Now that Tamas made the 'Expert' panel scrollable it is hard
not to use it for everything :-)
But 'Opaque Resize' should be under the 'Window Handling Preferences'.
In fact, there already exists the "Opaque Move" in there with a nice
icon and nice ballon box explanation. The "Opaque Resize" should be at
its side.
I know the small geometry of WPrefs is a pain (somebody should fix that :-)
but in this case you can try to squeeze the 'window placement' subpanel,
as there seems to occupy more space than needed.
--
To unsubscribe, send mail to [email protected].
