On Sat, 7 Jan 2012 at 13:04:35 -0500, David Rawson Couzelis wrote:
> >>"dock.c", line 1093
> >
> >That line is inside wDockCreate(), and I think it makes sense to
> >restrict the number of dockapps based on the screen size when
> >_creating_ the dock, right?
> >
> >I think the issue you have is related to the event of _restoring_ the
> >dock upon resolution change, look at wDockRestoreState().
> >And now it does not make sense to change the state of the dock
> >if we are _restoring_ it. So the fix should deal with this case
> >instead.
>
> The first thing "wDockRestoreState" does is call "wDockCreate".
> Actually, that's the only place "wDockCreate" is called.
>
> Near the end of "wDockRestoreState", line 1760, is where icons are
> removed from the dock if they don't fit.
for (i = 0; i < count; i++) {
if (dock->icon_count >= dock->max_icons) {
wwarning(_("there are too many icons stored in dock.
Ignoring what doesn't fit"));
break;
}
Hm, I don't think we can simply remove the 'break' there. Otherwise
someone could add dockapps by writing on the configuration files
directly and make things overflow.
> The patch I made increases the size of "dock->max_icons" to prevent
> them from being removed.
Ok. If nobody complains, I guess we can do that. After xrandr, fixing
the number of dockapps based on the screen resolution is not absolute
anymore.
But no WPrefs for that.
--
To unsubscribe, send mail to [email protected].
