On Thu, 19 Jan 2012 at 0:46:26 +0100, Rodolfo kix Garcia wrote: > [...]
I skipped your (a bit confusing) motivation. > Subject: [PATCH 1/2] WPrefs.app: Removing duplicated code > Subject: [PATCH 2/2] WINGs: Removed proplist-compat.h > > Comments are welcome. I hope the patches could be applied :-? The second patch is fine, the first is wrong (as you already noticed). There is something good in the first patch, which is the removal of the duplication on captureShortcut(). If you make a patch doing only that part, it's ok. And while at it, rename it to capture_shortcut(). [ BTW, the only reason there is a space after * in the functions arguments, char *captureShortcut(Display * dpy, _Panel * panel, int convertCase) is that I screwed up when using 'indent' some years ago. Whenever someone touches a line like that feel free to take the opportunity to turn it into: char *captureShortcut(Display *dpy, _Panel *panel, int convertCase) ] Your patch also did this at several places: > - WMSetTextFieldText(panel->shoT, NULL); > + WMSetTextFieldText(panel->shortT, NULL); making it much bigger and harder to review. But the new name is better, so if you make a patch doing only the rename that's ok too. -- To unsubscribe, send mail to [email protected].
