On 21/01/12 14:20, Carlos R. Mafra wrote: > On Sat, 21 Jan 2012 at 13:59:41 +0100, Rodolfo kix Garcia wrote: >> See the http://www.kix.es/src/wmaker/WPrefs.png file to see why I did the >> patches. > > Nice image. > >> The file <WINGs/WINGs.h> is included twice, one in this file and the >> other through WPrefs.h. For this reason I removed the direct include. > > But the rule I think is: If a file needs the definitions from a > particular .h file, it must include it directly.
Ok. But in the other images are different situations. Examples: 1. rootmenu.h is not included in files 2. usermenu.h is not included in files 3. wconfig.h has included config.h, but config.h don't exists 4. There are many many includes, I think this is not correct. Probably other schema is possible. I made these images to find these problems and help in the process to remove the externs. Best Regards, kix > The include guards exist to protect against the case you are > considering here. It's not good to depend on indirect includes like > you are proposing here. > > -- To unsubscribe, send mail to [email protected].
