On Mon, 27 Feb 2012 at 16:26:10 +0400, Alexey I. Froloff wrote:
> On Mon, Feb 27, 2012 at 12:14:24PM +0000, Carlos R. Mafra wrote:
> > Thanks for the patch, but it doesn't apply because it gets mangled by
> > the email server (or because you are using pgp)
> > Sending it attached should do the trick.
> OK. I'lll send it without commit message because this not a
> single commit.
Great, thanks a lot Alexey!
>
> > because "if" is not a function (so you need a space after it) and the
> > convention is to have the statement on a new line.
> Sure. Should I add empty lines around these ifs?
>
> if (flags & WFF_TITLEBAR) {
> theight = WMFontHeight(*fwin->font) + (*fwin->title_clearance +
> TITLEBAR_EXTEND_SPACE) * 2;
> if(theight > *fwin->title_max_height)
> theight = *fwin->title_max_height;
> if(theight < *fwin->title_min_height)
> theight = *fwin->title_min_height;
> } else
>
> vs.
>
> if (flags & WFF_TITLEBAR) {
> theight = WMFontHeight(*fwin->font) + (*fwin->title_clearance +
> TITLEBAR_EXTEND_SPACE) * 2;
>
> if(theight > *fwin->title_max_height)
> theight = *fwin->title_max_height;
>
> if(theight < *fwin->title_min_height)
> theight = *fwin->title_min_height;
> } else
>
> ?
The second version reads better.
--
To unsubscribe, send mail to [email protected].
