On Wed, 04 Apr 2012, Carlos R. Mafra escribió:

> On Wed,  4 Apr 2012 at 10:21:51 +0200, Rodolfo García Peñas wrote:
> > Subject: [PATCH 3/3] WindowMaker: Removed wApplicationDeactivate function
> > 
> > The wApplicationDeactivate is a function created by the preprocessor.
> > This small function can be removed and replaced for their contents,
> > because the code included is small and the same preprocessor block is
> > used before in other parts of the code.
> 
> I will not apply this patch, it uglifies the code by adding all those
> ifdefs. It's much cleaner to have the function call which does nothing
> if NEWAPPICON is not defined.
> 
> If you worry about the "function" being a macro, you should make it
> a proper function instead - which is always a good idea anyway.
> Making it a static inline in the case where NEWAPPICON is not defined
> is the usual thing to do.

Ok, I will do the function ASAP 8-)

Thanks for the uploads!
kix
-- 
||// //\\// Rodolfo "kix" Garcia
||\\// //\\ http://www.kix.es/


--
To unsubscribe, send mail to [email protected].

Reply via email to