El 05.04.2012 13:38, Carlos R. Mafra escribió:
On Thu, 5 Apr 2012 at 12:09:10 +0200, Rodolfo García Peñas wrote:
I think the repo has lag. Is something strange, because the patches
are
shown some hours later, but with a previous date. Do you have the
same
problem?
It's not a problem per se. I've been _very_ busy the last weeks and
I didn't apply the patches immediately. And when the patches are
applied, they retain their original date.
Ah! ok, thanks for the clarification.
There's lag in the commit notifications, but that's because the email
notification robot is not subscribed to the list, and John has to
manually approve them.
No problem, I was referring to the date of the patch.
I know that you normally do it, but in this situation (with lag),
please, can you send the confirmation about the push (or not).
I think all patches (except the one about class codes) are applied
now.
Thanks.
Finally, what do you think about
WindowMaker-Class-codes-cleaned.patch?
I do not feel confortable enough with this patch...I guess there's
still
something useful about having those unused classes in the sense of
documentation. And you had problems with the first iteration of the
patch,
so I thought that was another reason to leave it like that.
Ok, there are different things here:
1. The problem was that the value "0" is not used in the code
(WCLASS_DEFAULT), but the value "0" is used for an uninitialized
variables (linux?).
2. When I did the patch, I reassign the value 0 to Window WClass, then
I got some problems.
IMO, we have a bug. In some place the value is not initialized and this
is the reason because my patch failed.
I am working in other parts of the code, I will send a lot of patches
this week. I cannot check this problem now (probably we should add this
problem to the BUGS file or bug tracker).
I you are not comfortable, and I cannot check were the problem is,
probably is better to maintain the current code. If you want, I will try
to send other patch only with the code comments.
Thanks for your help/work.
kix
--
||// //\\// Rodolfo "kix" Garcia
||\\// //\\ http://www.kix.es/
--
To unsubscribe, send mail to [email protected].
