This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project wmaker-crm.git.

The branch, next has been updated
       via  b3afad67ff75dc7bd22b31b8370bbabd9786bbdd (commit)
       via  bca60318cab5ff9f01186c183696332e351b8d19 (commit)
       via  0601e0f002af38f3e33327a2fac39619d055b0f5 (commit)
      from  391a8edb9c39786014c62f3fec32bd9d126a7b19 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://repo.or.cz/w/wmaker-crm.git/commit/b3afad67ff75dc7bd22b31b8370bbabd9786bbdd

commit b3afad67ff75dc7bd22b31b8370bbabd9786bbdd
Author: Iain Patterson <[email protected]>
Date:   Tue Apr 10 10:55:26 2012 +0100

    Use noreturn attribute in Exit() declaration.
    
    Use the gcc-specific noreturn attribute to advise the compiler that
    Exit() doesn't return.  This is safe because we already use preprocessor
    rules to hide __attribute__ from other compilers.
    
    Suggested independently by Christophe Curis and Brad Jorsch.

diff --git a/src/funcs.h b/src/funcs.h
index ce9a99d..f64a40f 100644
--- a/src/funcs.h
+++ b/src/funcs.h
@@ -35,7 +35,7 @@ void Shutdown(WShutdownMode mode);
 
 void RestoreDesktop(WScreen *scr);
 
-void Exit(int status);
+void Exit(int status) __attribute__((noreturn));
 
 void Restart(char *manager, Bool abortOnFailure);
 

http://repo.or.cz/w/wmaker-crm.git/commit/bca60318cab5ff9f01186c183696332e351b8d19

commit bca60318cab5ff9f01186c183696332e351b8d19
Author: Iain Patterson <[email protected]>
Date:   Tue Apr 10 10:43:58 2012 +0100

    Compiler diet.
    
    Don't feed the compiler.  RelaunchWindow() is declared to return Bool so
    Bool it shall proudly return.

diff --git a/src/main.c b/src/main.c
index 0cda851..36f5a1e 100644
--- a/src/main.c
+++ b/src/main.c
@@ -456,10 +456,8 @@ Bool RelaunchWindow(WWindow *wwin)
                wAddDeathHandler(pid, (WDeathHandler *) shellCommandHandler, 
data);
 
                XFreeStringList(argv);
-               return True;
        }
 
-       /* compiler food */
        return True;
 }
 

http://repo.or.cz/w/wmaker-crm.git/commit/0601e0f002af38f3e33327a2fac39619d055b0f5

commit 0601e0f002af38f3e33327a2fac39619d055b0f5
Author: Iain Patterson <[email protected]>
Date:   Tue Apr 10 10:41:17 2012 +0100

    Style consistency.
    
    Approved style is not to write a single-operation for loop in a single line.

diff --git a/src/main.c b/src/main.c
index 6696c2c..0cda851 100644
--- a/src/main.c
+++ b/src/main.c
@@ -435,7 +435,8 @@ Bool RelaunchWindow(WWindow *wwin)
                }
 
                int i;
-               for (i = 0; i < argc; i++) a[i] = argv[i];
+               for (i = 0; i < argc; i++)
+                       a[i] = argv[i];
                a[i] = NULL;
 
                execvp(a[0], a);

-----------------------------------------------------------------------

Summary of changes:
 src/funcs.h |    2 +-
 src/main.c  |    5 ++---
 2 files changed, 3 insertions(+), 4 deletions(-)


repo.or.cz automatic notification. Contact project admin [email protected]
if you want to unsubscribe, or site admin [email protected] if you receive
no reply.
-- 
wmaker-crm.git ("The Window Maker window manager")


-- 
To unsubscribe, send mail to [email protected].

Reply via email to