On Fri, 4 May 2012 at 22:57:39 +0200, Tobias Stoeckmann wrote:
> From 252e6e59b17d4477fec19b41f443b4c4c4bea908 Mon Sep 17 00:00:00 2001
> From: Tobias Stoeckmann <[email protected]>
> Date: Fri, 4 May 2012 22:53:04 +0200
> Subject: [PATCH] No need to call memset after wmalloc
Thanks for the patch. I have just one comment and it's not really
related to your patch.
> diff --git a/WPrefs.app/Menu.c b/WPrefs.app/Menu.c
> index 342e7f0..e9eaa9b 100644
> --- a/WPrefs.app/Menu.c
> +++ b/WPrefs.app/Menu.c
> @@ -155,7 +155,7 @@ static char *commandNames[] = {
> "LEGAL_PANEL"
> };
>
> -#define NEW(type) memset(wmalloc(sizeof(type)), 0, sizeof(type))
> +#define NEW(type) wmalloc(sizeof(type))
I think it would be even better to get rid of the #define and use
wmalloc() directly in those few places.
--
To unsubscribe, send mail to [email protected].
