On Fri, 15 Jun 2012 at 23:06:18 +0200, Rodolfo García Peñas wrote: > Subject: [PATCH] Icon painting moved to makeAppIconFor() > > The icon painting is moved to the function makeAppIconFor() > including the check for no_appicon. > > wAppIconCreate is now static because is only used in makeAppIconFor() > The function is moved above to avoid the prototype creation.
No, moving the position of a function inside the same file to avoid the prototype is not a good reason. It makes the patch artificially bigger and does not set a good precedent. Could you please respin the patch without the moving? Furthermore, does any of your later patches depend on your "experimental" ones? > --- > src/appicon.c | 93 > ++++++++++++++++++++++++++--------------------------- > src/appicon.h | 1 - > src/application.c | 4 --- > 3 files changed, 46 insertions(+), 52 deletions(-) -- To unsubscribe, send mail to [email protected].
