On Fri, 15 Jun 2012 at 20:21:57 +0200, Rodolfo García Peñas wrote: > > This commit includes: > > Application.c: > - The appicon is always created and saved, only painted if needed. > - The extractIcon function is removed, because their behaiour is > done by save_app_icon. Now save_app_icon is called allways, if > no_appicon is set or not. Because the extractIcon is removed, > the function GetProgramNameForWindow (misc.c) can be deleted. > - The app_icon stuff is moved from application.c to appicon.c: > - wApplicationExtractDirPackIcon() moved and now static. > - app_icon_create_from_docks() moved and now is not static, > because this the only function is called in application.c > - findDockIconFor() moved (was and is static). > - wApplicationSaveIconPathFor() moved and now static. > - Some includes and externs removed in application.c. > > Appicon.h: > - wAppIconChangeImage() revoved, because is only declared. > --- > src/appicon.c | 189 > +++++++++++++++++++++++++++++++++++++++++++---------- > src/appicon.h | 11 ++-- > src/application.c | 171 +++--------------------------------------------- > src/application.h | 4 -- > src/icon.c | 2 +- > src/misc.c | 6 -- > 6 files changed, 171 insertions(+), 212 deletions(-)
This change is too big, and it looks like there's too much moving of functions. Just suppose that this commit introduces a regression. I think this patch needs to be split. It's doing too much at the same time. -- To unsubscribe, send mail to [email protected].
