> When this happens we assume that you've already had alert emails for all > of the O revisions, and so we here report only the revisions in the N > branch from the common base, B. > > Those revisions listed above that are new to this repository have > not appeared on any other notification email; so we list those > revisions in full, below. > > - Log ----------------------------------------------------------------- > http://repo.or.cz/w/wmaker-crm.git/commit/f97b997f382f466e40c851575bbb971f64db2d3b > > commit f97b997f382f466e40c851575bbb971f64db2d3b > Author: Carlos R. Mafra <[email protected]> > Date: Thu Jun 21 16:51:12 2012 +0100 > > Skip no_appicon apps in the application icon list > > We want to avoid having to consider the position of an appicon whose > application has no_appicon set. The appicon is not "painted" so it > does not appear on the screen. But if the appicon is still added to > the list of application icons, the wArrangeIcons() function gets > confused and ends up creating holes in the icon positions which > correspond to the no_appicon apps. > > Signed-off-by: Carlos R. Mafra <[email protected]> > > diff --git a/src/appicon.c b/src/appicon.c > index 3999458..6e6b87a 100644 > --- a/src/appicon.c > +++ b/src/appicon.c > @@ -247,12 +247,17 @@ static WAppIcon *wAppIconCreate(WWindow * > leader_win) > aicon->yindex = -1; > aicon->xindex = -1; > > - aicon->prev = NULL; > - aicon->next = scr->app_icon_list; > - if (scr->app_icon_list) > - scr->app_icon_list->prev = aicon; > - > - scr->app_icon_list = aicon; > + /* When no_appicon is set we want to avoid having it on the list > + * because otherwise there will be a hole when the icons are > + * arranged with wArrangeIcons() */ > + if (!WFLAGP(leader_win, no_appicon)) { > + aicon->prev = NULL; > + aicon->next = scr->app_icon_list; > + if (scr->app_icon_list) > + scr->app_icon_list->prev = aicon; > + > + scr->app_icon_list = aicon; > + } > > if (leader_win->wm_class) > aicon->wm_class = wstrdup(leader_win->wm_class); >
I checked this patch today. app_icon_list is only used in the wArrangeIcons and similar functions, therefore, the patch is ok. Thanks Carlos. kix -- Rodolfo García AKA kix http://www.kix.es/ EA4ERH (@IN80ER) -- To unsubscribe, send mail to [email protected].
