> On Sat, 23 Jun 2012 at 19:04:29 +0200, Rodolfo GarcÃa Peñas wrote:
>> Subject: [PATCH] Simplify the header files
>>
>> Remove the not-used includes that don't need include includes in the
>> .c files.
>
> :-)
>
>> diff --git a/src/appicon.h b/src/appicon.h
>> index 1fbd976..7f0c252 100644
>> --- a/src/appicon.h
>> +++ b/src/appicon.h
>> @@ -23,11 +23,7 @@
>> #ifndef WMAPPICON_H_
>> #define WMAPPICON_H_
>>
>> -#include <wraster.h>
>> -
>> -#include "window.h"
>> #include "icon.h"
>> -#include "application.h"
>>
>> typedef struct WAppIcon {
>> short xindex;
>
>
> I'm afraid this is not right. For example, appicon.h must know what
> WApplication (defined in application.h) is because it has, inter alia,
>
> void paint_app_icon(WApplication *wapp);
>
> It also uses 'Window', which AFAICT is defined in X11/X.h, which is
> indirectly included via wraster.h
>
> I haven't looked the rest of the patch.
I will take a look, but we have a lot of includes, and is hard remove the
externs, find the functions,... because the header files are dirty.
Did you see the previous patch?:
Remove code duplication in winmenu.c
And the problem with stacking?
Thanks!
--
Rodolfo García AKA kix
http://www.kix.es/
EA4ERH (@IN80ER)
--
To unsubscribe, send mail to [email protected].
