On Mon, 25 Jun 2012 at 23:48:51 +0200, Rodolfo García Peñas wrote:
>
> Subject: [PATCH 07/11] net_state_from_client can be removed
>
> The variable net_state_from_client don't change their value in the
> code, therefore, we don't need check it in any "if".
> ---
> src/window.h | 1 -
> src/wmspec.c | 4 +---
> 2 files changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/src/window.h b/src/window.h
> index e2d516a..ae1e704 100644
> --- a/src/window.h
> +++ b/src/window.h
> @@ -290,7 +290,6 @@ typedef struct WWindow {
>
> unsigned int user_changed_width:1;
> unsigned int user_changed_height:1;
> - unsigned int net_state_from_client:1; /* state hint was set by
> client */
> unsigned int net_skip_pager:1;
> unsigned int net_handle_icon:1;
> unsigned int net_show_desktop:1;
> diff --git a/src/wmspec.c b/src/wmspec.c
> index 9456841..ae870ea 100644
> --- a/src/wmspec.c
> +++ b/src/wmspec.c
> @@ -795,9 +795,7 @@ static void updateWorkspaceHint(WWindow * wwin, Bool
> fake, Bool del)
> static void updateStateHint(WWindow * wwin, Bool changedWorkspace, Bool del)
> { /* changeable */
> if (del) {
> - if (!wwin->flags.net_state_from_client) {
> - XDeleteProperty(dpy, wwin->client_win, net_wm_state);
> - }
> + XDeleteProperty(dpy, wwin->client_win, net_wm_state);
I don't know. I wonder if we should try to look where and when
we should set this variable.
--
To unsubscribe, send mail to [email protected].
