----- kix <[email protected]> a écrit : > El 2012-07-01 20:41, Christophe escribió: > > Hello All, > > > > The goal of these 7 patches is to remove the dependency to CPP which > > is currently used to pre-process the menu definition file. > > > > The main reasons we'd wish to do this is: > > - most users don't do dev, so the distributions do not install GCC > > by default, so we're adding them a strong dependency; > > - not all C compilers actually provides a CPP now, the example being > > the rising CLANG (from LLVM) which has valuable reasons to do so. > > > > Because the default menu provided by WindowMaker does need these > > features, we cannot simply get rid of the code, or we'd break > > compatibility with our user base. > > Although this means some added complexity in WindowMaker, because > > this is likely to improve performances: > > - no more sub-process to call external CPP program; > > - less 'wmalloc/wfree' calls which are expensive (both in term of > > performance and memory fragmentation) than in original code. > > > > The first patch is a preparation for the new parser into a dedicated > > file; the patches 2 to 6 add support for features of the parser and > > patch 7 concludes by removing code calling CPP. That means that no > > patch should break anything. > > > > Best Regards, > > Christophe. > > Hi, > > your patch don't apply > > I got an error about rootmenu.h:41. > > What branch did you use? What was the last commit? > > Best Regards, > kix
Hi kix, It looks like you submitted a patch that touched that file between the time I started working and the patch proposal, and I missed the corresponding pull hence the misalignment :-( Fixed, so I re-submit the patches! Thanks for having given a try! Regards, Christophe. -- To unsubscribe, send mail to [email protected].
