On Wed, 04 Jul 2012, Carlos R. Mafra escribió: > On Tue, 3 Jul 2012 at 19:34:38 +0200, Rodolfo García Peñas wrote: > > Subject: [PATCH 04/13] wDefaultGetImage splitted > > > > -static void wApplicationExtractDirPackIcon(WScreen * scr, char *path, char > > *wm_instance, char *wm_class) > > +void wApplicationExtractDirPackIcon(WScreen * scr, char *path, char > > *wm_instance, char *wm_class) > > You could take the opportunity to write WScreen *scr instead of having > the space... > > > > +/* Get the file name of the image, using instance and class */ > > +char *get_default_icon_filename(WScreen *scr, char *winstance, char > > *wclass, char *command, > > + Bool noDefault) > > The comment should include a description of the noDefault parameter. > Btw, it's a bad idea to have a boolean parameter which is a negation > of something. I find it more natural to have > > Default = True > > instead of > > noDefault = False > > when you want the Default case.
I agree. The double negation is difficult some times. But we need a "full patch", because is used in some functions. kix -- ||// //\\// Rodolfo "kix" Garcia ||\\// //\\ http://www.kix.es/ -- To unsubscribe, send mail to [email protected].
