On Tue, 9 Oct 2012 at 0:58:19 +0200, Christophe wrote: > ----- Rodolfo García Peñas <[email protected]> a écrit : > > > > From ade4a2246b8c6f76df2c9c5a4799c356b29d0b94 Mon Sep 17 00:00:00 2001 > > From: =?UTF-8?q?"Rodolfo=20Garc=C3=ADa=20Pe=C3=B1as=20(kix)"?= <[email protected]> > > Date: Sat, 6 Oct 2012 15:15:51 +0200 > > Subject: [PATCH] New function remove_wwindowstate > > > > The common code in the functions wWindowDeleteSavedState and > > wWindowDeleteSavedStatesForPID is moved to a new function > > remove_wwindowstate. > > --- > > src/window.c | 54 ++++++++++++++++++++++-------------------------------- > > 1 file changed, 22 insertions(+), 32 deletions(-) > > > > Hi, > > It's a bit late to say anything about this has it has already been > imported in the Repository, but I'd like to make a small comment:
It's never too late. The branch 'next' is meant to be rebased when the need arrives. > you name the function "remove_*", which makes think that it would > remove the entry from the list, but the function does not do that, it > just frees the memory, so it may have been better called "free_" (or > maybe "release_")? > Good point, release_ makes more sense to me. -- To unsubscribe, send mail to [email protected].
