Hi Christophe,

only one thing. See the code at screen.c (createInternalWindows() func):

 457         /* shadow window for dock buttons */
 458         vmask = CWBorderPixel | CWBackPixmap | CWBackPixel | CWCursor | 
CWSaveUnder | CWOverrideRedirect;
 459         attribs.border_pixel = scr->black_pixel;
 460         attribs.save_under = True;
 461         attribs.override_redirect = True;
 462         attribs.background_pixmap = None;
 463         attribs.background_pixel = scr->white_pixel;
 464         attribs.cursor = wCursor[WCUR_DEFAULT];
 465         vmask |= CWColormap;

Probably we can do the same here. I don't know (I need more time), if is 
possible use the wcore functions in screen.c

Best Regards,
kix

On Wed, 10 Oct 2012, Christophe escribió:


> From 2adcb534b0ea01c1d9061b85915ef4435f63565b Mon Sep 17 00:00:00 2001
> From: Christophe CURIS <[email protected]>
> Date: Wed, 10 Oct 2012 23:07:53 +0200
> Subject: [PATCH] Fixed incorrect attributes for XCreateWindow's attributes
> 
> The code was setting some values in the window's attribute structure
> which were not being used (missing the corresponding vmask flag) and
> was setting some vmask bits without setting the corresponding
> value in the structure.
> ---
>  src/wcore.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/src/wcore.c b/src/wcore.c
> index 1abe842..3650591 100644
> --- a/src/wcore.c
> +++ b/src/wcore.c
> @@ -51,10 +51,9 @@ WCoreWindow *wCoreCreateTopLevel(WScreen *screen, int x, 
> int y, int width, int h
>  
>       core = wmalloc(sizeof(WCoreWindow));
>  
> -     vmask = CWBorderPixel | CWCursor | CWEventMask | CWOverrideRedirect | 
> CWColormap;
> +     vmask = CWBackPixel | CWBorderPixel | CWCursor | CWEventMask | 
> CWOverrideRedirect | CWColormap;
>       attribs.override_redirect = True;
>       attribs.cursor = wCursor[WCUR_DEFAULT];
> -     attribs.background_pixmap = None;
>       attribs.background_pixel = screen->black_pixel;
>       attribs.border_pixel = screen->frame_border_pixel;
>       attribs.event_mask = SubstructureRedirectMask | ButtonPressMask |
> @@ -98,9 +97,8 @@ WCoreWindow *wCoreCreate(WCoreWindow *parent, int x, int y, 
> int width, int heigh
>  
>       core = wmalloc(sizeof(WCoreWindow));
>  
> -     vmask = CWBorderPixel | CWCursor | CWEventMask | CWColormap;
> +     vmask = CWBackPixel | CWCursor | CWEventMask | CWColormap;
>       attribs.cursor = wCursor[WCUR_DEFAULT];
> -     attribs.background_pixmap = None;
>       attribs.background_pixel = parent->screen_ptr->black_pixel;
>       attribs.event_mask = KeyPressMask | KeyReleaseMask | ButtonPressMask |
>                            ButtonReleaseMask | ButtonMotionMask |
> -- 
> 1.7.10.4
> 


-- 
||// //\\// Rodolfo "kix" Garcia
||\\// //\\ http://www.kix.es/


-- 
To unsubscribe, send mail to [email protected].

Reply via email to