This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project wmaker-crm.git.
The branch, next has been updated
via 5dcd31acbe94959656e4d971c0f4b462a0bfb7c7 (commit)
from 92d52523c411d10be08e3af28fc5ac924b2f5075 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://repo.or.cz/w/wmaker-crm.git/commit/5dcd31acbe94959656e4d971c0f4b462a0bfb7c7
commit 5dcd31acbe94959656e4d971c0f4b462a0bfb7c7
Author: Carlos R. Mafra <[email protected]>
Date: Wed Nov 14 10:20:27 2012 +0000
appicon: Avoid double 'Hide' entry
On 12.11.2012 Paul Seelig reported:
- open an application positioning an app icon on the bottom
- right click this app icon to show the context menu
- wonder yourself why there are two lines saying "Hide"
- first Hide entry does not do anything, second does
The reason for this curious behavior is the following.
The "Launch" entry was added in 8352c9ef60 ("Allow relaunch with shortcut
key")
as the first one in the appicon menu, but this first position was hard-coded
in another part of wmaker's code in order to decide the menu entry text
based
on the application's 'hidden' state in openApplicationMenu():
if (wapp->flags.hidden)
menu->entries[1]->text = _("Unhide");
else
menu->entries[1]->text = _("Hide");
But the "Launch" entry is before these "Hide/Unhide" entries and now the
assumption
about entries[1] containing the relevant string for this hide/unhide
decision is
no longer valid.
The simpler "fix" is to move the "Launch" entry below these "Hide/Unhide"
games.
diff --git a/src/appicon.c b/src/appicon.c
index 329bd6e..ac0c4ba 100644
--- a/src/appicon.c
+++ b/src/appicon.c
@@ -577,9 +577,9 @@ static WMenu *createApplicationMenu(WScreen *scr)
WMenu *menu;
menu = wMenuCreate(scr, NULL, False);
- wMenuAddCallback(menu, _("Launch"), relaunchCallback, NULL);
wMenuAddCallback(menu, _("Unhide Here"), unhideHereCallback, NULL);
wMenuAddCallback(menu, _("Hide"), hideCallback, NULL);
+ wMenuAddCallback(menu, _("Launch"), relaunchCallback, NULL);
wMenuAddCallback(menu, _("Set Icon..."), setIconCallback, NULL);
wMenuAddCallback(menu, _("Kill"), killCallback, NULL);
-----------------------------------------------------------------------
Summary of changes:
src/appicon.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
repo.or.cz automatic notification. Contact project admin [email protected]
if you want to unsubscribe, or site admin [email protected] if you receive
no reply.
--
wmaker-crm.git ("The Window Maker window manager")
--
To unsubscribe, send mail to [email protected].
