This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project wmaker-crm.git.
The branch, next has been updated
via 18437e0309bbb9d9d9791b384625b15bc52a65f1 (commit)
from 3d470167882799fc38699ec22f5198450cfe5df0 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://repo.or.cz/w/wmaker-crm.git/commit/18437e0309bbb9d9d9791b384625b15bc52a65f1
commit 18437e0309bbb9d9d9791b384625b15bc52a65f1
Author: Carlos R. Mafra <[email protected]>
Date: Sat Dec 22 02:23:24 2012 +0000
WINGs: Enable cursor blinking in text fields
This code was commented out but enabling it leads to no issues AFAICS
and improves the usability of WINGs applications.
The motivation for this patch comes from the need of distinguishing
where the cursor is in the WINGs-based application which handles the
database of my comics collection.
This changes the behavior in all parts of wmaker where there is
a text field entry, e.g. in the settings panel of dockapps. There should
be no issues with a blinking cursor in such cases though...
diff --git a/WINGs/wtextfield.c b/WINGs/wtextfield.c
index 4d4c645..52221a9 100644
--- a/WINGs/wtextfield.c
+++ b/WINGs/wtextfield.c
@@ -40,9 +40,8 @@ typedef struct W_TextField {
WMTextFieldDelegate *delegate;
-#if 0
WMHandlerID timerID; /* for cursor blinking */
-#endif
+
struct {
WMAlignment alignment:2;
@@ -863,7 +862,6 @@ static void paintTextField(TextField * tPtr)
}
}
-#if 0
static void blinkCursor(void *data)
{
TextField *tPtr = (TextField *) data;
@@ -876,7 +874,6 @@ static void blinkCursor(void *data)
paintCursor(tPtr);
tPtr->flags.cursorOn = !tPtr->flags.cursorOn;
}
-#endif
static void handleEvents(XEvent * event, void *data)
{
@@ -890,11 +887,11 @@ static void handleEvents(XEvent * event, void *data)
if (W_FocusedViewOfToplevel(W_TopLevelOfView(tPtr->view)) !=
tPtr->view)
return;
tPtr->flags.focused = 1;
-#if 0
+
if (!tPtr->timerID) {
tPtr->timerID =
WMAddTimerHandler(CURSOR_BLINK_ON_DELAY, blinkCursor, tPtr);
}
-#endif
+
paintTextField(tPtr);
NOTIFY(tPtr, didBeginEditing,
WMTextDidBeginEditingNotification, NULL);
@@ -905,11 +902,10 @@ static void handleEvents(XEvent * event, void *data)
case FocusOut:
W_UnFocusIC(tPtr->view);
tPtr->flags.focused = 0;
-#if 0
+
if (tPtr->timerID)
WMDeleteTimerHandler(tPtr->timerID);
tPtr->timerID = NULL;
-#endif
paintTextField(tPtr);
if (!tPtr->flags.notIllegalMovement) {
@@ -1532,10 +1528,8 @@ static void handleTextFieldActionEvents(XEvent * event,
void *data)
static void destroyTextField(TextField * tPtr)
{
-#if 0
if (tPtr->timerID)
WMDeleteTimerHandler(tPtr->timerID);
-#endif
W_DestroyIC(tPtr->view);
-----------------------------------------------------------------------
Summary of changes:
WINGs/wtextfield.c | 14 ++++----------
1 files changed, 4 insertions(+), 10 deletions(-)
repo.or.cz automatic notification. Contact project admin [email protected]
if you want to unsubscribe, or site admin [email protected] if you receive
no reply.
--
wmaker-crm.git ("The Window Maker window manager")
--
To unsubscribe, send mail to [email protected].
