On Sun, 27 Jan 2013 at 20:02:13 +0100, Rodolfo García Peñas wrote:
> On Sun, 27 Jan 2013, Andreas Bierfert escribió:
>
> > From 294b0f10829bd3c6fec0f5b50ccd451ecd076be1 Mon Sep 17 00:00:00 2001
> > From: Andreas Bierfert <[email protected]>
> > Date: Sun, 27 Jan 2013 17:11:38 +0100
> > Subject: [PATCH 2/2] Use same parsing code for generated and external
> > submenus
> ...
> > + if(!plist)
> > + return NULL;
> ...
> > + if(!menu)
> > + return NULL;
>
> Hi Andreas!
>
> :-)
>
> and in the patch 1/2 in one place. IMO, don't try to find things using
> your eyes, use the "find" option of your editor. For example, to find
> whitespaces at the end of the lines, the find tool is needed.
Well, if the idea is to be picky about coding style one can comply
with wmaker's standards very easily using checkpatch.pl from the
linux kernel.
For example, running it in the mailbox where I saved his email (which
is not how checkpatch should be ideally used - it's meant to be run
on the outcome of 'git format-patch') generates these warnings:
[mafra@linux-ahr8:linux-2.6]$ ./scripts/checkpatch.pl ../Mail/andreas.bierfert
ERROR: patch seems to be corrupt (line wrapped?)
#61: FILE: src/rootmenu.c:981:
ame)
ERROR: spaces required around that '=' (ctx:WxV)
#65: FILE: src/rootmenu.c:984:
+ WMPropList *plist =3D NULL;
^
WARNING: Avoid CamelCase: <WMPropList>
#65: FILE: src/rootmenu.c:984:
+ WMPropList *plist =3D NULL;
ERROR: spaces required around that '=' (ctx:WxV)
#107: FILE: src/rootmenu.c:998:
+ plist =3D WMReadPropListFromPipe(filename);
^
WARNING: Avoid CamelCase: <WMReadPropListFromPipe>
#107: FILE: src/rootmenu.c:998:
+ plist =3D WMReadPropListFromPipe(filename);
WARNING: suspect code indent for conditional statements (8, 12)
#111: FILE: src/rootmenu.c:999:
+ if(!plist)
+ return NULL;
ERROR: space required before the open parenthesis '('
#111: FILE: src/rootmenu.c:999:
+ if(!plist)
ERROR: spaces required around that '=' (ctx:WxV)
#116: FILE: src/rootmenu.c:1001:
+ menu =3D configureMenu(scr, plist, False);
^
WARNING: Avoid CamelCase: <configureMenu>
#116: FILE: src/rootmenu.c:1001:
+ menu =3D configureMenu(scr, plist, False);
WARNING: Avoid CamelCase: <False>
#116: FILE: src/rootmenu.c:1001:
+ menu =3D configureMenu(scr, plist, False);
WARNING: suspect code indent for conditional statements (8, 12)
#117: FILE: src/rootmenu.c:1002:
+ if(!menu)
+ return NULL;
ERROR: space required before the open parenthesis '('
#117: FILE: src/rootmenu.c:1002:
+ if(!menu)
ERROR: spaces required around that '=' (ctx:WxV)
#120: FILE: src/rootmenu.c:1004:
+ menu->on_destroy =3D removeShortcutsForMenu;
^
WARNING: Avoid CamelCase: <removeShortcutsForMenu>
#120: FILE: src/rootmenu.c:1004:
+ menu->on_destroy =3D removeShortcutsForMenu;
ERROR: Missing Signed-off-by: line(s)
total: 8 errors, 7 warnings, 69 lines checked
../Mail/andreas.bierfert has style problems, please review.
--
To unsubscribe, send mail to [email protected].
