On 20/03/2013 22:59, Carlos R. Mafra wrote: > On Wed, 20 Mar 2013 at 20:37:39 +0100, "Rodolfo García Peñas (kix)" wrote: >> >> But, anyway, I think return WAppIcon when we are trying to create a >> WDock struct is wrong and all functions about Dock/Clip should work >> with WDock structs. >> >> Comments? > > Unless you find bugs I'd recomend to not touch these things now. > > Because despite some unusual things at some places, all that code > has been proven by time and it simply works. And at this moment I think > that preserving the stability of wmaker is much more important than > anything else. > > Small additions here and there, small tweaks to improve the usability > is how the development should proceed -- there were some people in > wmaker-user wanting to move windows to other workspaces using keyboard > shortcuts, and I think wmaker could have that option. > > The (mis)behavior of the xrandr code is also one outstanding thing > which annoys some people. > > Massive cleanups in core objects smells like trouble and should have > a very compelling reason to be accepted at this (very stable) point.
I can continue with my other things! :-) Ok, no problem. The current code seems to be stable, but we now that some things "could be better". We can stop here for a while and continue "testing" this stable code and only solve bugs. But the problem is that (probably) we are building over code with some problems. I am not talking about code with bugs, is about bad design. This design make difficult to do some things (like xrandr, yes) and other things. Yes the things works, but that doesn't mean that they are fine. For example, the Clip is created in one function (I don't remember the name, sorry), is painted in 0,0, without the arrows. Then, some code later (with the dock painted! on 0,0), the clip is fully created and moved to the right position. This is because when the screen/workspace (I don't remember now) is created, they recover the Clip, but don't fully create it. The clip is created later, when the main icons are painted. This is wrong, the clip and the dock should be created in only one point, in one step. I think we can rewrite this part and remove a lot of code. But, perfect. I agree with you in stop here. Sometimes I have dreams (nightmares?) with wmaker code. I spent more time that I have on it. I will swap to my other things. Perhaps could be a good idea about you post the wmaker plan (calendar? dates?). I sent 6 patches that I extract from the pts.tgz. Feel free to apply them or save them for the future. Finally, if the code is "frozen for a while" with changes about design, could be a good idea check the documentation, the web and create a BTS in windowmaker.org. I cc John for the BTS. Thanks Carlos, Best regards, Rodolfo. PS: sleep(); -- ||// //\\// Rodolfo "kix" Garcia ||\\// //\\ http://www.kix.es/ -- To unsubscribe, send mail to [email protected].
