After the question about Drawers (see the other mail), some quick comments:
On Fri, 22 Mar 2013, [email protected] escribió: > From: Daniel Déchelotte <[email protected]> [snip] > --- a/src/WindowMaker.h > +++ b/src/WindowMaker.h > @@ -443,7 +443,9 @@ typedef struct WPreferences { > struct { > unsigned int nodock:1; /* don't display the dock */ > unsigned int noclip:1; /* don't display the clip */ > - unsigned int nodrawer:1; /* don't use drawers */ > + unsigned int nodrawer:1; /* don't use drawers */ If this line was added in a previous patch, and it have problems (spaces, tabs,...) it should changed (rebased) in the previous patch. I see in other patches problems with spaces at the end of the line. > + unsigned int wrap_appicons_in_dock:1; /* Whether to wrap appicons > when Dock is moved up and down */ This function is wrong: > +static int setWrapAppiconsInDock(WScreen *scr, WDefaultEntry *entry, char > *flag, void *foo) > +{ scr, entry and foo are not used, so, the prototype should be setWrapAppiconsInDock(char *flag) > + wPreferences.flags.wrap_appicons_in_dock = *flag; > + return 0; If the function always returns "0", then, should be void: void setWrapAppiconsInDock(char *flag) { wPreferences.flags.wrap_appicons_in_dock = *flag; } And then.... why not remove the function and set the preferences in the line where you call the function? OTOH, where is the function used? > @@ -3126,9 +3126,9 @@ void wDockRaise(WDock *dock) > wRaiseFrame(dock->icon_array[i]->icon->core); > } > if (dock->type == WM_DOCK) { > - for (dc = dock->screen_ptr->drawers; dc != NULL; dc = dc->next) > - wDockRaise(dc->adrawer); > - } > + for (dc = dock->screen_ptr->drawers; dc != NULL; dc = dc->next) > + wDockRaise(dc->adrawer); > + } > } I did these clean things many times :-) and Carlos always told me that should be in different patches. He is right ;-) (shhh, don't tell it to him) Probably you can send different patches to the code style and the new behavior. I didn't check the rest of the patch, I will wait the reply about Drawers. kix. -- ||// //\\// Rodolfo "kix" Garcia ||\\// //\\ http://www.kix.es/ -- To unsubscribe, send mail to [email protected].
