> From: "Rodolfo García Peñas (kix)" <[email protected]> > [...] > diff --git a/src/workspace.c b/src/workspace.c > index f333e10..5bc8ba0 100644 > --- a/src/workspace.c > +++ b/src/workspace.c > @@ -608,23 +608,14 @@ void wWorkspaceForceChange(WScreen * scr, int > workspace) > wAppIconPaint(scr->dock->icon_array[0]); > > /* The Clip in the current workspace */ > - if (scr->workspaces[workspace]->clip->icon_array[0]) { > - if (scr->workspaces[workspace]->clip->auto_collapse || > - scr->workspaces[workspace]->clip->auto_raise_lower) { > - /* to handle enter notify. This will also */ > - XUnmapWindow(dpy, > scr->workspaces[workspace]->clip->icon_array[0]->icon->core->window); > - XMapWindow(dpy, > scr->workspaces[workspace]->clip->icon_array[0]->icon->core->window); > - } else { > - > wClipIconPaint(scr->workspaces[workspace]->clip->icon_array[0]); > - } > - } > + if (scr->workspaces[workspace]->clip->icon_array[0]) > + wClipIconPaint(scr->workspaces[workspace]->clip->icon_array[0]); > +
It's unfortunate that that comment got chopped off /* to handle enter notify. This will also */ Perhaps the end of the sentence was "[This will also] force a redraw of the clip's appicon", justifing that wClipIconPaint() is not explicitly called. At any rate, the XUnmapWindow followed by a XMapWindow may look useless at first blush, but I think they are there for a reason: to trigger the necessary auto_raise/lower/collapse/expand events (as alluded to in the comment). I'll add a one-line patch to complete the comment (assuming consensus on continuation of the comment. Can someone look up in the file's history to see if we have it?) -- Daniel -- To unsubscribe, send mail to [email protected].
