On 12/04/2013 1:42, [email protected] wrote:
> From: Daniel Déchelotte <[email protected]>
>
> Add WrapAppiconsInDock option to control that behaviour (default: YES)
> ---
As I said in my previous comments, this functions are not right:
>
> +static int setWrapAppiconsInDock(WScreen *scr, WDefaultEntry *entry, char
> *flag, void *foo)
> +{
> + wPreferences.flags.wrap_appicons_in_dock = *flag;
> + return 0;
> +}
you are passing arguments that you don't use, you are returning always
the same value, so, the funcion should be void. Then, one function for
only one line?
I am not really confortable with the patches. Yes, the drawers
functionality is incredible, but the IMHO the cost is very high.
Cheers,
kix
--
||// //\\// Rodolfo "kix" Garcia
||\\// //\\ http://www.kix.es/
--
To unsubscribe, send mail to [email protected].
