----- Rodolfo García Peñas <[email protected]> a écrit :
> On Wed, 01 May 2013, Christophe escribió:
> 
> > Hello,
> > 
> > I am proposing these 8 patches that make some updates to the WRaster
> > (wrlib) with no functional change, the goal is to have cleaner code.
> > 
> > Patchs 1 to 3 move some things to a new internal header;
> > Patchs 4 to 7 add some 'const' attribute to provide hints to the compiler;
> > Patch 8 officialise the change in the API
> > 
> > Best regards,
> > Christophe
> 
> Hi Christophe,
> 
> probably something is wrong. The types are different, "char" and "const 
> char". See the output below.


Yep, something was wrong, should be fixed now!
I forgot I did not enable GIF support on my side (was lazy to install gif-dev), 
but thanks to your review, that should be allright now.


> 
> Cheers,
> kix
> 
> /bin/bash ../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I..  
>  -I/usr/include  -D_FORTIFY_SOURCE=2  -g -O2 -fstack-protector 
> --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall 
> -DGLOBAL_DEFAULTS_SUBDIR=\"GNUstep/Defaults\" -D_XOPEN_SOURCE=600 -MT gif.lo 
> -MD -MP -MF .deps/gif.Tpo -c -o gif.lo gif.c
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include 
> -D_FORTIFY_SOURCE=2 -g -O2 -fstack-protector --param=ssp-buffer-size=4 
> -Wformat -Werror=format-security -Wall 
> -DGLOBAL_DEFAULTS_SUBDIR=\"GNUstep/Defaults\" -D_XOPEN_SOURCE=600 -MT gif.lo 
> -MD -MP -MF .deps/gif.Tpo -c gif.c  -fPIC -DPIC -o .libs/gif.o
> gif.c:42:9: error: conflicting types for 'RLoadGIF'
> imgformat.h:68:9: note: previous declaration of 'RLoadGIF' was here
> make[4]: *** [gif.lo] Error 1
> make[4]: se sale del directorio `/home/kix/src/tmp/wmaker/wmaker-crm/wrlib'
> make[3]: *** [all-recursive] Error 1
> make[3]: se sale del directorio `/home/kix/src/tmp/wmaker/wmaker-crm/wrlib'
> make[2]: *** [all-recursive] Error 1
> make[2]: se sale del directorio `/home/kix/src/tmp/wmaker/wmaker-crm'
> make[1]: *** [all] Error 2
> make[1]: se sale del directorio `/home/kix/src/tmp/wmaker/wmaker-crm'
> dh_auto_build: make -j1 returned exit code 2
> make: *** [build] Error 2
> dpkg-buildpackage: fallo: debian/rules build devolvió un estado de salida de 
> error 2
> kix@debian:~/src/tmp/wmaker$ cd -
> /home/kix/src/tmp/wmaker/wmaker-crm
> kix@debian:~/src/tmp/wmaker/wmaker-crm$ cd wrlib/
> kix@debian:~/src/tmp/wmaker/wmaker-crm/wrlib$ grep RLoadGIF *[ch]
> gif.c:RImage *RLoadGIF(char *file, int index)
> imgformat.h:RImage *RLoadGIF(const char *file, int index);
> load.c:         image = RLoadGIF(file, index);
> kix@debian:~/src/tmp/wmaker/wmaker-crm/wrlib$


--
To unsubscribe, send mail to [email protected].

Reply via email to