Quoth Carlos R. Mafra,
The Workspaces entry in the main menu allows to rename workspaces by clicking on the workspace name while pressing the Ctrl key.
I did not know that...
This happens because there is an explicit offset in the current code (- 2) to account for the "non-workspace" entries in the menu. If one adds one more entry that offset should be changed too (this is a prime example of fragile code leading to bugs).
Prior to breaking it with commit 63219247c6c7 I had attempted to get rid of the corresponding magic numbers. See 9b27217b53d9. As I didn't know about the workspace renaming I didn't think to look for the -2 you just fixed.
Should we consider moving the MC_* #defines (and others) to WindowMaker.h or some other shared header so that the code is less fragile?
-- To unsubscribe, send mail to [email protected].
