On Sun, 16 Jun 2013 at 17:46:46 +0200, Christophe wrote:
> 
> ----- Carlos R. Mafra <[email protected]> a écrit :
> > On Sat, 15 Jun 2013 at 14:38:45 +0200, Christophe wrote:
> > > From: Christophe CURIS <[email protected]>
> > > 
> > > Because we have to use some X functions marked as deprecated to
> > > ensure portability, we prefer to hide the warnings from standard
> > > users, and keep them only for dev team.
> > 
> > No, it's better not to hide these warnings. They are useful to
> > tell us about rotten code, and the more people annoyed by them
> > the better chances we have to get them addressed.
> 
> My concern was to avoid false reports from user on these specific functions, 
> but that's perfectly ok for me if you want to keep them. The ideal case would 
> be to be able to disable them only for Xlib, which is not possible...

I ended up applying it, but I also added -Wno-deprecated-declarations on
top of your patch, since otherwise the warnings would not go away here.

> 
> 
> > > 
> > > Signed-off-by: Christophe CURIS <[email protected]>
> > > ---
> > >  configure.ac |    8 ++++++++
> > >  1 file changed, 8 insertions(+)
> > > 
> > > diff --git a/configure.ac b/configure.ac
> > > index 2f04b02..d2e145d 100644
> > > --- a/configure.ac
> > > +++ b/configure.ac
> > > @@ -104,6 +104,14 @@ AS_IF([test "x$debug" = "xyes"],
> > >       dnl
> > >       dnl Use of 'sizeof()' on inappropriate pointer types
> > >       AX_CFLAGS_GCC_OPTION([-Wpointer-arith])
> > > +], [dnl
> > > +     dnl When debug not enabled, we try to avoid some non-necessary
> > > +     dnl messages from the compiler
> > > +     dnl
> > > +     dnl To support legacy X servers, we have sometime to use
> > > +     dnl functions marked as deprecated. We do not wish our users
> > > +     dnl to be worried about it
> > > +     AX_CFLAGS_GCC_OPTION([-Wno-deprecated])
> > >  ])
> > >  
> > >  dnl Platform-specific Makefile setup
> > > -- 
> > > 1.7.10.4
> 
> 
> --
> To unsubscribe, send mail to [email protected].


-- 
To unsubscribe, send mail to [email protected].

Reply via email to