On Thu, 29 Aug 2013 at 9:06:43 +0000, Rodolfo García Peñas (kix) wrote: > > About the idea of push to #next is perfect. I will send a lot of > patches the next months and I think is better push them on #next and > test them some time. I am testing patches here, without problems, but > I will send the patches grouping them, to make the things easier. The > groups (now) are: > > 1.- New struct with workspace info [Done] > 2.- Split icon creation and icon paint/mapping for icons (in wrlib). [Done] > 3.- Split wcore creation and wcore paint/mapping (in scr). [Done] > 4.- Unify Drawers/Clip/Docks in the same struct. Create functions for > paint / draw them. [Working]. > 5.- XRandR support. We need that create and paint/mapping/recover were > splitted first (previous steps). [Old patches, waiting]. > > I would like to create all the stuff and then send the patches, to > avoid make patches of patches. Probably I will send only patches about > "code style" and bugs. I am rebasing and rebasing patches to send > these patches first (it is a bit boring for me, but is good for us). > If after all the work it not make much sense then I won't send > nothing, except the code clean and bugs.
Yes, putting the code cleanups and bug fixes first is essential! We have to be really cautious about not breaking things but even more importantly is the reversible nature of the changes if problems are identified (and you have been very careful about that even if that means extra work). You don't need to rush too much about your code. Submit it after you are confortable with the changes (and their ordering) and after they pass your own use of wmaker. > Only one thing. I didn't test it, but probably we can remove the > wrlib/nxpm.c file, because the "Normalized XPM" probably won't work as > expected. I will appreciate if you can test it (using the flag > "USE_XPM" define). Ok. Thansk for your work. -- To unsubscribe, send mail to [email protected].
