On Sat, 5 Oct 2013 at 0:53:52 +0200, Christophe wrote: > > ----- Rodolfo García Peñas (kix) <[email protected]> a écrit : > > The new struct wks_info includes the global information > > for the workspaces. All information related with the workspaces > > should be included here. > > > > The first variable moved is workspace_name_font, included in this > > patch. This variable was included in the screen info, but the > > screen and the font used in the workspace name don't have any > > relationship. > > > > Signed-off-by: Rodolfo García Peñas (kix) <[email protected]> > > --- > > [...] > > > > diff --git a/src/workspace.h b/src/workspace.h > > index 69d1b18..68cd275 100644 > > --- a/src/workspace.h > > +++ b/src/workspace.h > > @@ -23,12 +23,16 @@ > > #define WMWORKSPACE_H_ > > > > > > - > > typedef struct WWorkspace { > > char *name; > > struct WDock *clip; > > } WWorkspace; > > > > +typedef struct WWorkspace_info { > > + /* Workspace stuff */ > > + WMFont *workspace_name_font; > > +} WWorkspace_info; > > + > > Hi, > > May I suggest, as this is a global variable, to place it the the global > structure instead? You could define something like: > > struct { > WMFont *font_for_name; > } workspace; > > and put it somewhere around src/WindowMaker.h:483 > That way, the variable would be accessed via: > w_global.workspace.font_for_name > which would make it look a bit more expressive from my point of view.
That's a good idea. -- To unsubscribe, send mail to [email protected].
